Ensure that TS can report todo comments even prior to us having connected to the OOP server.#43410
Conversation
…hooking up to the OOP server.
713d4ea to
a6c64a8
Compare
|
I exist! |
|
@tmat @jasonmalinowski PTAL. This is for partner team to help with the pain i caused over moving Todo OOP. |
|
Wrking to get confirmation from TS this solves their problem. Once we know for certain, we can merge. |
|
I don't fully understand this work queue implementation, but the idea seems sensible. @rachelgshaffer would be the one to confirm practical correctness for TS. 👍 |
|
While you're touching this file, you might want to clean up the TS-specific method at the bottom - it will never find a tree for the document. |
Good point :) |
|
I was able to debug and verify this works from the TS side. thanks for your help! |
Fixes #43320 (comment)
TS is going to be reporting these comments using their own mechanism for scheduling. Technically, nothing ensures that they will be runnign after we "start" (i.e. hook up to OOP) our TODO service. This is esp. the case since we launch this in a Fire-And-Forget manner in async-package-load.
This PR just makes us resilient to the TS calling into us before that. In that case, all we do is just have their call await us actually getting started and then from that point on everything is hooked up properly and messages are processed normally.