Merged
Conversation
genlu
approved these changes
Apr 23, 2020
jasonmalinowski
approved these changes
Apr 23, 2020
|
|
||
| <!-- By default build assets that define embedded interop types do not flow. Set PrivateAssets to none to make them flow. --> | ||
| <PackageReference Include="Microsoft.VisualStudio.SDK.EmbedInteropTypes" Version="$(MicrosoftVisualStudioSDKEmbedInteropTypesVersion)" PrivateAssets="none" /> | ||
| <PackageReference Include="Microsoft.VisualStudio.StaticReviews.Embeddable" Version="$(MicrosoftVisualStudioStaticReviewsEmbeddableVersion)" PrivateAssets="none" /> |
Member
There was a problem hiding this comment.
There's build assets in this too? I thought we had a special rule in our VisualStudio.props that was also embedding this?
Member
Author
There was a problem hiding this comment.
Yes, there is one. We can probably remove ours.
Member
Author
|
Are integration tests broken? |
Member
|
Good to merge? |
Member
Author
|
Yes, thanks for merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default PackageReference does not flow build targets.