Merge master to features/covariant-returns#46436
Merged
68 commits merged intofeatures/covariant-returnsfrom Jul 31, 2020
Merged
Merge master to features/covariant-returns#4643668 commits merged intofeatures/covariant-returnsfrom
68 commits merged intofeatures/covariant-returnsfrom
Conversation
All the IDE diagnostic analyzer computation has now been moved to OOP: 1. Span-based diagnostic computation (lightbulb) 2. Background analysis for active an open documents 3. Background project analysis 4. Diagnostic computation for default workspace layer DefaultDiagnosticAnalyzerService. Diagnostics are computed in OOP by default, if the remote service provider exists. Otherwise, it falls back to in-proc computation, similar to the way project level analysis works today. TODO: Add some OOP specific unit tests for open file analysis. Even though this is primarily a performance optimization, we still need to add some tests similar to existing project level OOP execution unit tests to ensure OOP execution is the default for all these modes.
…t leads to significant memory pressure. Diagnostics from project analysis are already cached in VS side, so we will not do any redundant analysis.
…fix_cps Remove CPS restriction for applying rename during code fix
Do not persist winforms data to disk
|
Hello @dotnet-bot! Because this pull request has the Do note that I've been instructed to only help merge pull requests of this repository that have been opened for at least 12 minutes. No worries though, I will be back when the time is right! 😉 p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
…dworkspace-test remove test that aserts .NET Standard should be prefered over .NET Framework
…-to-master Merge release/dev16.8-preview1 to master
Move open file diagnostic analysis to OOP
Consolidate the skip link for TestDefaultDiagnosticProviderRemove
Tweak delays we have before we start incrementally analyzing in OOP.
Added search option for inline parameter name hints
…features/covariant-returns
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automatically generated pull request from master into features/covariant-returns.
git fetch --all git checkout merges/master-to-features/covariant-returns git reset --hard upstream/features/covariant-returns git merge upstream/master # Fix merge conflicts git commit git push upstream merges/master-to-features/covariant-returns --forceOnce all conflicts are resolved and all the tests pass, you are free to merge the pull request.