Skip to content

remove test that aserts .NET Standard should be prefered over .NET Framework#43010

Merged
1 commit merged intodotnet:masterfrom
jmarolf:bugfix/remove-incorrect-msbuildworkspace-test
Jul 30, 2020
Merged

remove test that aserts .NET Standard should be prefered over .NET Framework#43010
1 commit merged intodotnet:masterfrom
jmarolf:bugfix/remove-incorrect-msbuildworkspace-test

Conversation

@jmarolf
Copy link
Contributor

@jmarolf jmarolf commented Apr 2, 2020

fixes #42772

@jmarolf jmarolf requested a review from a team as a code owner April 2, 2020 02:12
Copy link
Member

@jasonmalinowski jasonmalinowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should also be deleting the GetNetCoreMultiTFMFiles_ProjectReferenceWithReversedTFMs method and it's supporting files. I don't see anything else using them.

@jmarolf jmarolf force-pushed the bugfix/remove-incorrect-msbuildworkspace-test branch from 5383231 to 8496551 Compare July 29, 2020 21:22
@jmarolf jmarolf dismissed jasonmalinowski’s stale review July 29, 2020 21:22

deleted resources

@ghost
Copy link

ghost commented Jul 29, 2020

Hello @jmarolf!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approval

@ghost ghost merged commit fc9eb0c into dotnet:master Jul 30, 2020
@ghost ghost added this to the Next milestone Jul 30, 2020
@RikkiGibson RikkiGibson modified the milestones: Next, 16.8.P2 Aug 11, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestOpenProject_NetCoreMultiTFM_ProjectReferenceWithReversedTFMs unnecessarily asserts netstandard2.0 is selected over net461

4 participants