Skip to content

Fix stack overflow in requesting syntax directives#36347

Merged
agocke merged 2 commits intodotnet:masterfrom
agocke:parser-overflow
Jun 18, 2019
Merged

Fix stack overflow in requesting syntax directives#36347
agocke merged 2 commits intodotnet:masterfrom
agocke:parser-overflow

Conversation

@agocke
Copy link
Copy Markdown
Member

@agocke agocke commented Jun 11, 2019

Fixes #36346

@agocke agocke added this to the 16.2 milestone Jun 11, 2019
@agocke agocke marked this pull request as ready for review June 12, 2019 17:45
@agocke agocke requested a review from a team as a code owner June 12, 2019 17:45

EstimatorChain <ColumnCopyingTransformer> GenerateDataPipeline(MLContext mlContext, LightGbmMulticlassTrainer.Options options)
{
return mlContext.Transforms.Conversion.MapValueToKey(outputColumnName: KeyColumn, inputColumnName: Label)");
Copy link
Copy Markdown
Member

@gafter gafter Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

" [](start = 117, length = 1)

You probably need a newline so the #region starts on a line. #Closed

{
srcBuilder.AppendLine(@".Append(mlContext.Transforms.NormalizeLogMeanVariance(inputColumnName: ""F40714"", outputColumnName:""NF40714""))");
}
srcBuilder.AppendLine("#endregion");
Copy link
Copy Markdown
Member

@gafter gafter Jun 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

srcBuilder [](start = 12, length = 10)

Need a semicolon at the end of the fluent call chain. #Closed

Copy link
Copy Markdown
Member

@gafter gafter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@agocke
Copy link
Copy Markdown
Member Author

agocke commented Jun 13, 2019

@dotnet/roslyn-compiler For a short review

@agocke agocke merged commit be33f9e into dotnet:master Jun 18, 2019
@agocke agocke deleted the parser-overflow branch June 18, 2019 20:33
333fred added a commit to 333fred/roslyn that referenced this pull request Jun 18, 2019
…-types

* dotnet/master: (63 commits)
  Fix stack overflow in requesting syntax directives (dotnet#36347)
  crash on ClassifyUpdate for EventFields (dotnet#35962)
  Disable move type when the options service isn't present (dotnet#36334)
  Fix crash where type inference doing method inference needs to drop nullability
  Fix parsing bug in invalid using statements (dotnet#36428)
  Do not suggest or diagnose use compound assignment when right hand of binary operator is a throw expression
  Add option to emit nullable metadata for public members only (dotnet#36398)
  Added null checks on F# external access services (dotnet#36469)
  Deal with discovering extra .editorconfig files
  Re-enable MSBuildWorkspaceTests.TestEditorConfigDiscovery
  Add support to VisualStudioMSBuildInstalled to support minimum versions
  Fix configuration of accessibilities in editorconfig
  Shorten a resource ID
  Revert "Extract the RDT implementation for Misc files and VS open file tracker"
  Add nullability support to use local function
  Add EditorFeatures.WPF dependency to F# ExternalAccess
  Ensure NullableWalker.AsMemberOfType locates the right new container for the member. (dotnet#36406)
  Replace `dynamic` with `object` when substituting constraints. (dotnet#36379)
  Add some string descriptions
  Adjust type of out var based on parameter state (dotnet#36284)
  ...
333fred added a commit to 333fred/roslyn that referenced this pull request Jun 20, 2019
* dotnet/master: (85 commits)
  Don't complete statement when typing semicolon inside comments in an argument list (dotnet#36521)
  Set focus to editor before finding text
  Add a bunch of nullability support to some code generation helpers
  Add 'annotations' and 'warnings' support to nullable directive (dotnet#36464)
  Fixed IDE services touching `notnull` constraint (dotnet#36508)
  Update compiler toolset to arcade version (dotnet#36549)
  Fix for 923157
  Do not include value types in NullableAttribute byte[] (dotnet#36519)
  Fix a deadlock in InvokeOnUIThread
  Apply a hang mitigating timeout to UI thread operations
  Move to a different lowering from for nullable value types to work around a bug in TransformCompoundAssignmentLHS. Addressed PR feedback.
  Fix stack overflow in requesting syntax directives (dotnet#36347)
  crash on ClassifyUpdate for EventFields (dotnet#35962)
  fixing bad merge with refactoring that was checked in later
  added basic completion statement telemetry
  Remove duplication in AbstractSymbolCompletionProvider.CreateItems
  Disable move type when the options service isn't present (dotnet#36334)
  Fix crash where type inference doing method inference needs to drop nullability
  Revert "Use IVsSolution to look up IVsHierarchy by project GUID (dotnet#35746)"
  Fix parsing bug in invalid using statements (dotnet#36428)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

C# Parser can stack overflow when GetDirectives is called on a SyntaxNodeOrToken

3 participants