Disable move type when the options service isn't present#36334
Disable move type when the options service isn't present#36334ryzngard merged 5 commits intodotnet:masterfrom
Conversation
src/EditorFeatures/CSharpTest/MoveToNamespace/MoveToNamespaceTests.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest/MoveToNamespace/MoveToNamespaceTests.cs
Outdated
Show resolved
Hide resolved
src/EditorFeatures/CSharpTest/MoveToNamespace/MoveToNamespaceTests.cs
Outdated
Show resolved
Hide resolved
| int position, | ||
| CancellationToken cancellationToken) | ||
| { | ||
| var moveToNamespaceOptionsService = document.Project.Solution.Workspace.Services.GetService<IMoveToNamespaceOptionsService>(); |
There was a problem hiding this comment.
❔ Why not in GetCodeActionsAsync?
|
💡 Consider moving the dependency further up into the |
src/Features/CSharp/Portable/MoveToNamespace/CSharpMoveToNamespaceService.cs
Outdated
Show resolved
Hide resolved
|
@sharwell I think I have the MEF requirements correct now. This still can't checked in until I find out what's going on with OOP MEF stuff. I'm following up with @heejaechang for that |
|
Part rejection is not enabled, so I used |
| namespace Microsoft.CodeAnalysis.Test.Utilities.MoveToNamespace | ||
| { | ||
| [ExportWorkspaceService(typeof(IMoveToNamespaceOptionsService)), Shared] | ||
| [Export(typeof(IMoveToNamespaceOptionsService)), Shared] |
There was a problem hiding this comment.
📝 Parts defined in test assemblies need [PartNotDiscoverable]
…-types * dotnet/master: (63 commits) Fix stack overflow in requesting syntax directives (dotnet#36347) crash on ClassifyUpdate for EventFields (dotnet#35962) Disable move type when the options service isn't present (dotnet#36334) Fix crash where type inference doing method inference needs to drop nullability Fix parsing bug in invalid using statements (dotnet#36428) Do not suggest or diagnose use compound assignment when right hand of binary operator is a throw expression Add option to emit nullable metadata for public members only (dotnet#36398) Added null checks on F# external access services (dotnet#36469) Deal with discovering extra .editorconfig files Re-enable MSBuildWorkspaceTests.TestEditorConfigDiscovery Add support to VisualStudioMSBuildInstalled to support minimum versions Fix configuration of accessibilities in editorconfig Shorten a resource ID Revert "Extract the RDT implementation for Misc files and VS open file tracker" Add nullability support to use local function Add EditorFeatures.WPF dependency to F# ExternalAccess Ensure NullableWalker.AsMemberOfType locates the right new container for the member. (dotnet#36406) Replace `dynamic` with `object` when substituting constraints. (dotnet#36379) Add some string descriptions Adjust type of out var based on parameter state (dotnet#36284) ...
* dotnet/master: (85 commits) Don't complete statement when typing semicolon inside comments in an argument list (dotnet#36521) Set focus to editor before finding text Add a bunch of nullability support to some code generation helpers Add 'annotations' and 'warnings' support to nullable directive (dotnet#36464) Fixed IDE services touching `notnull` constraint (dotnet#36508) Update compiler toolset to arcade version (dotnet#36549) Fix for 923157 Do not include value types in NullableAttribute byte[] (dotnet#36519) Fix a deadlock in InvokeOnUIThread Apply a hang mitigating timeout to UI thread operations Move to a different lowering from for nullable value types to work around a bug in TransformCompoundAssignmentLHS. Addressed PR feedback. Fix stack overflow in requesting syntax directives (dotnet#36347) crash on ClassifyUpdate for EventFields (dotnet#35962) fixing bad merge with refactoring that was checked in later added basic completion statement telemetry Remove duplication in AbstractSymbolCompletionProvider.CreateItems Disable move type when the options service isn't present (dotnet#36334) Fix crash where type inference doing method inference needs to drop nullability Revert "Use IVsSolution to look up IVsHierarchy by project GUID (dotnet#35746)" Fix parsing bug in invalid using statements (dotnet#36428) ...
Fixes #35577