Fixed IDE services touching notnull constraint#36508
Conversation
|
Looking good. Did i miss it, or are there no completion tests here? |
NotNullKeywordRecommenderTests were added in #36109. Is this what you were looking for? |
|
Indeed. Sorry, i missed that PR the last time around! |
| End Get | ||
| End Property | ||
|
|
||
| Private ReadOnly Property HasNotNullConstraint As Boolean Implements ITypeParameterSymbol.HasNotNullConstraint |
There was a problem hiding this comment.
HasNotNullConstraint [](start = 34, length = 20)
Consider adding an API test for VB (we already had tests for the C# API)
jcouv
left a comment
There was a problem hiding this comment.
LGTM Thanks (compiler and IDE changes, iteration 1)
|
@dotnet/roslyn-compiler Please review, need a second sign-off. |
|
@dotnet/roslyn-ide Please review |
|
@dotnet/roslyn-compiler Please review, need a second sign-off. |
|
@dotnet/roslyn-ide Please review |
|
@dotnet/roslyn-ide Please review |
1 similar comment
|
@dotnet/roslyn-ide Please review |
| new NameOfKeywordRecommender(), | ||
| new NamespaceKeywordRecommender(), | ||
| new NewKeywordRecommender(), | ||
| new NotNullKeywordRecommender(), |
There was a problem hiding this comment.
Is there a test for this?
What kind of test do you have in mind?
There was a problem hiding this comment.
Check if notnull shows as keyword in completion list
Ah, I see I have missed the comments above. Please ignore this. (although it's concerning that the test you added before didn't catch this)
jasonmalinowski
left a comment
There was a problem hiding this comment.
Late but do want to give kudos for all the good work adding tests.
* dotnet/master: (85 commits) Don't complete statement when typing semicolon inside comments in an argument list (dotnet#36521) Set focus to editor before finding text Add a bunch of nullability support to some code generation helpers Add 'annotations' and 'warnings' support to nullable directive (dotnet#36464) Fixed IDE services touching `notnull` constraint (dotnet#36508) Update compiler toolset to arcade version (dotnet#36549) Fix for 923157 Do not include value types in NullableAttribute byte[] (dotnet#36519) Fix a deadlock in InvokeOnUIThread Apply a hang mitigating timeout to UI thread operations Move to a different lowering from for nullable value types to work around a bug in TransformCompoundAssignmentLHS. Addressed PR feedback. Fix stack overflow in requesting syntax directives (dotnet#36347) crash on ClassifyUpdate for EventFields (dotnet#35962) fixing bad merge with refactoring that was checked in later added basic completion statement telemetry Remove duplication in AbstractSymbolCompletionProvider.CreateItems Disable move type when the options service isn't present (dotnet#36334) Fix crash where type inference doing method inference needs to drop nullability Revert "Use IVsSolution to look up IVsHierarchy by project GUID (dotnet#35746)" Fix parsing bug in invalid using statements (dotnet#36428) ...
No description provided.