Skip to content

Ensure NullableWalker.AsMemberOfType locates the right new container for the member.#36406

Merged
AlekseyTs merged 1 commit intodotnet:masterfrom
AlekseyTs:Issue36018
Jun 14, 2019
Merged

Ensure NullableWalker.AsMemberOfType locates the right new container for the member.#36406
AlekseyTs merged 1 commit intodotnet:masterfrom
AlekseyTs:Issue36018

Conversation

@AlekseyTs
Copy link
Copy Markdown
Contributor

Fixes #36018.

@AlekseyTs AlekseyTs requested a review from a team as a code owner June 13, 2019 17:04
@jcouv jcouv added this to the 16.2.P4 milestone Jun 13, 2019
@AlekseyTs
Copy link
Copy Markdown
Contributor Author

@dotnet/roslyn-compiler Please review.

@AlekseyTs
Copy link
Copy Markdown
Contributor Author

@dotnet/roslyn-compiler, @cston Please review, need a second sign-off.

@AlekseyTs AlekseyTs merged commit 3ac1a7d into dotnet:master Jun 14, 2019
333fred added a commit to 333fred/roslyn that referenced this pull request Jun 18, 2019
…-types

* dotnet/master: (63 commits)
  Fix stack overflow in requesting syntax directives (dotnet#36347)
  crash on ClassifyUpdate for EventFields (dotnet#35962)
  Disable move type when the options service isn't present (dotnet#36334)
  Fix crash where type inference doing method inference needs to drop nullability
  Fix parsing bug in invalid using statements (dotnet#36428)
  Do not suggest or diagnose use compound assignment when right hand of binary operator is a throw expression
  Add option to emit nullable metadata for public members only (dotnet#36398)
  Added null checks on F# external access services (dotnet#36469)
  Deal with discovering extra .editorconfig files
  Re-enable MSBuildWorkspaceTests.TestEditorConfigDiscovery
  Add support to VisualStudioMSBuildInstalled to support minimum versions
  Fix configuration of accessibilities in editorconfig
  Shorten a resource ID
  Revert "Extract the RDT implementation for Misc files and VS open file tracker"
  Add nullability support to use local function
  Add EditorFeatures.WPF dependency to F# ExternalAccess
  Ensure NullableWalker.AsMemberOfType locates the right new container for the member. (dotnet#36406)
  Replace `dynamic` with `object` when substituting constraints. (dotnet#36379)
  Add some string descriptions
  Adjust type of out var based on parameter state (dotnet#36284)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interface deriving from IEquatable<T> twice triggers CS8620 on wrong interface

4 participants