Skip to content

Determine size of auto cells in GridLayout correctly when views occupy same cell#2391

Merged
PureWeen merged 1 commit intomainfrom
grid-stacked-auto-sizing
Sep 3, 2021
Merged

Determine size of auto cells in GridLayout correctly when views occupy same cell#2391
PureWeen merged 1 commit intomainfrom
grid-stacked-auto-sizing

Conversation

@hartez
Copy link
Contributor

@hartez hartez commented Sep 3, 2021

GridLayout has a bug when multiple views occupy the same row/column and the row/column sizing is set to Auto - the cell does not properly grow to the size of the largest view in some circumstances.

Theses changes add unit tests for various scenarios and fix the broken ones.

@PureWeen PureWeen merged commit ab16f9c into main Sep 3, 2021
@PureWeen PureWeen deleted the grid-stacked-auto-sizing branch September 3, 2021 22:27
Csaba8472 added a commit to Csaba8472/maui that referenced this pull request Sep 6, 2021
* upstream/main: (326 commits)
  Re-enable interpreter on blazor by default
  Determine size of auto cells in GridLayout correctly when views occupy same cell (dotnet#2391)
  [main] Update dependencies from xamarin/xamarin-macios (dotnet#2326)
  [Android] Fix Horizontal Scrollbar Visibility (dotnet#2374)
  Try start vs4mac with local dotnet (dotnet#2386)
  [workoad] include missing dependencies in the workload (dotnet#2281)
  Update project templates to work with safe characters (dotnet#2368)
  [release/6.0.1xx-rc1] Update dependencies from xamarin/xamarin-android (dotnet#2369)
  Update dependencies from https://github.com/xamarin/xamarin-macios build 20210903.3 (dotnet#2384)
  Bump manifest to use api 31 (dotnet#2366)
  BoxView Handlers (dotnet#2250)
  Implement IsTextPredictionEnabled in WinUI Editor (dotnet#1478)
  Implement PlaceholderColor property in EntryHandlers (dotnet#1513)
  Automated dotnet-format update (dotnet#2355)
  Show entire search bar by default and make it not collapse (dotnet#2351)
  Remove test cloud if def for now (dotnet#2350)
  Add support for JS root components in BlazorWebView (dotnet#2293)
  Set base viewmapper to work against IViewHandler (dotnet#2339)
  NavigationView Handler for Android (dotnet#2336)
  Update OutputType to WinExe on -windows (dotnet#2340)
  ...
@Redth Redth added this to the 6.0.101-preview.9 milestone Sep 27, 2021
@samhouts samhouts added area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter layout-grid labels Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
@samhouts samhouts added the fixed-in-6.0.101-preview.10 Look for this fix in 6.0.101-preview.10! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-layout StackLayout, GridLayout, ContentView, AbsoluteLayout, FlexLayout, ContentPresenter fixed-in-6.0.101-preview.10 Look for this fix in 6.0.101-preview.10! layout-grid

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants