Update project templates to work with safe characters#2368
Conversation
jonathanpeppers
left a comment
There was a problem hiding this comment.
Right now when I use this template in VS 2022, it does:
Is that going to have a .1 in the name now? So the picture would show MauiApp.4?
|
I'd also like to note: While this change moves away from the concept of "Runnable templates" because it's now using default names that are invalid (e.g. |
|
@jonathanpeppers good question and I think the answer is that it's unchanged from before because we still set |
|
Also, I tested locally with a silly name in the form of |
|
And... I also meant to update the template test to use a silly name, so I'll get that figured out and push an update in a few moments. |
jonathanpeppers
left a comment
There was a problem hiding this comment.
Ok, one thing that would be great is to put a weird character in the name here:
Line 113 in 4e18b84
Then we'd have CI verifying this keeps working.
|
Yup, that's what I will do, once I can get it to run locally (it seems I always have something out of date!). |
|
Looks like there was a bug in cake 1.0.0 where binlogs with spaces in them weren't escaped (cake-build/cake#2559), but that's been fixed. I've updated to Cake 1.2.0... let's see how that goes...! |
This reverts commit 1362b04.
This comment has been minimized.
This comment has been minimized.
|
And of course it turns out we don't have Cake 1.2.0 on our internal feeds, so I've reverted to Cake 1.0.0 and manually quoted all binlog names. I logged #2372 to update Cake and revert my binlog quote fix. |
This comment has been minimized.
This comment has been minimized.
|
Hi @Pakon2543 , can we help you with something? I'm not sure I understand the various comments/reviews you've put on several MAUI items... |
Co-authored-by: Jonathan Dick <jodick@microsoft.com>
Co-authored-by: Jonathan Dick <jodick@microsoft.com>
|
@Redth the CI looks happy now, just need an approval. @vlada-shubina thank you for the review! |
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
- Update project templates to work with safe characters (dotnet#2368)
Fixes #2176
To learn more about the seemingly-odd
MauiApp.1andMauiApp._1stuff you'll now see, read here: https://github.com/dotnet/templating/wiki/Naming-and-default-value-formsTL;DR: The template engine is clever enough to understand different substitution patterns (rather than just blanket search & replace), so if you follow certain conventions, the template engine will use the correct substitution you need for cases where there are restricted character sets, such as C# namespaces and class names.
@vlada-shubina - I've also tagged you here as a reviewer because it seems like you're the expert on this. Thank you in advance if you're able to review this!