GH2558: fix quote filename of binary logger#2559
Merged
augustoproiete merged 1 commit intocake-build:developfrom Feb 9, 2021
FroggieFrog:fix-quote-binarylogger-filename
Merged
GH2558: fix quote filename of binary logger#2559augustoproiete merged 1 commit intocake-build:developfrom FroggieFrog:fix-quote-binarylogger-filename
augustoproiete merged 1 commit intocake-build:developfrom
FroggieFrog:fix-quote-binarylogger-filename
Conversation
Contributor
Author
|
Breaking build checks seem not to be related to this PR. |
Contributor
Author
|
Is there any information if this will be included in the next release (> 0.33.0)? |
Contributor
Author
|
Is there anything I can do to get it merged sooner? |
patriksvensson
previously approved these changes
Oct 11, 2019
patriksvensson
requested changes
Oct 11, 2019
Member
patriksvensson
left a comment
There was a problem hiding this comment.
Looks good to me, but the PR branch requires a rebase and a squash so it's a single commit.
Member
|
@FroggieFrog your changes have been merged, thanks for your contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should fix issue #2558.
It also includes unit tests.
I don't know if
MSBuildBinaryLogSettings.FileNameshould really be of typeFilePathinstead ofstringlikeMSBuildFileLogger.LogFileis.