Skip to content

Implement PlaceholderColor property in EntryHandlers#1513

Merged
rmarinho merged 8 commits intomainfrom
entry-placeholdercolor
Sep 2, 2021
Merged

Implement PlaceholderColor property in EntryHandlers#1513
rmarinho merged 8 commits intomainfrom
entry-placeholdercolor

Conversation

@jsuarezruiz
Copy link
Contributor

Description of Change

Implement PlaceholderColor property in EntryHandlers

Platforms

  • Android
  • iOS
  • macOS
  • Windows

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)
  • Targets a single property for a single control (or intertwined few properties)
  • Adds the property to the appropriate interface
  • Avoids any changes not essential to the handler property
  • Adds the mapping to the PropertyMapper in the handler
  • Adds the mapping method to the Android, iOS, and Standard aspects of the handler
  • Implements the actual property updates (usually in extension methods in the Platform section of Core)
  • Tags ported renderer methods with [PortHandler]
  • Adds an example of the property to the sample project (MainPage)
  • Adds the property to the stub class
  • Implements basic property tests in DeviceTests

Does this PR touch anything that might affect accessibility?

  • No

@rmarinho rmarinho merged commit 940d383 into main Sep 2, 2021
@rmarinho rmarinho deleted the entry-placeholdercolor branch September 2, 2021 15:07
Csaba8472 added a commit to Csaba8472/maui that referenced this pull request Sep 6, 2021
* upstream/main: (326 commits)
  Re-enable interpreter on blazor by default
  Determine size of auto cells in GridLayout correctly when views occupy same cell (dotnet#2391)
  [main] Update dependencies from xamarin/xamarin-macios (dotnet#2326)
  [Android] Fix Horizontal Scrollbar Visibility (dotnet#2374)
  Try start vs4mac with local dotnet (dotnet#2386)
  [workoad] include missing dependencies in the workload (dotnet#2281)
  Update project templates to work with safe characters (dotnet#2368)
  [release/6.0.1xx-rc1] Update dependencies from xamarin/xamarin-android (dotnet#2369)
  Update dependencies from https://github.com/xamarin/xamarin-macios build 20210903.3 (dotnet#2384)
  Bump manifest to use api 31 (dotnet#2366)
  BoxView Handlers (dotnet#2250)
  Implement IsTextPredictionEnabled in WinUI Editor (dotnet#1478)
  Implement PlaceholderColor property in EntryHandlers (dotnet#1513)
  Automated dotnet-format update (dotnet#2355)
  Show entire search bar by default and make it not collapse (dotnet#2351)
  Remove test cloud if def for now (dotnet#2350)
  Add support for JS root components in BlazorWebView (dotnet#2293)
  Set base viewmapper to work against IViewHandler (dotnet#2339)
  NavigationView Handler for Android (dotnet#2336)
  Update OutputType to WinExe on -windows (dotnet#2340)
  ...
@ghost ghost added the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label Jul 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Dec 25, 2023
@Eilon Eilon removed the legacy-area-controls Label, Button, CheckBox, Slider, Stepper, Switch, Picker, Entry, Editor label May 10, 2024
@samhouts samhouts added the fixed-in-6.0.101-preview.10 Look for this fix in 6.0.101-preview.10! label Aug 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants