[release/6.0.1xx-rc1] Update dependencies from xamarin/xamarin-android by dotnet-maestro[bot] · Pull Request #2369 · dotnet/maui

dotnet-maestro · 2021-09-02T19:33:19Z

This pull request updates the following dependencies

Coherency Updates

The following updates ensure that dependencies with a CoherentParentDependency
attribute were produced in a build used as input to the parent dependency's build.
See Dependency Description Format

Coherency Updates:
- Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.Dotnet.Sdk.Internal)
- Microsoft.Dotnet.Sdk.Internal: from 6.0.100-rc.1.21426.23 to 6.0.100-rc.1.21452.4 (parent: Microsoft.Android.Sdk.Windows)
- Microsoft.Extensions.Primitives: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.AspNetCore.App.Runtime.win-x64: from 6.0.0-rc.1.21425.34 to 6.0.0-rc.1.21451.36 (parent: Microsoft.Dotnet.Sdk.Internal)
- Microsoft.Extensions.Hosting: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.Extensions.Hosting.Abstractions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.Extensions.DependencyInjection.Abstractions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.Extensions.DependencyInjection: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.Extensions.Configuration.Abstractions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.Extensions.Configuration: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.Extensions.Logging.Abstractions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.Extensions.Logging: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.Extensions.Logging.Console: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.Extensions.Logging.Debug: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.Extensions.FileProviders.Abstractions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)
- Microsoft.AspNetCore.Authorization: from 6.0.0-rc.1.21425.34 to 6.0.0-rc.1.21451.36 (parent: Microsoft.Dotnet.Sdk.Internal)
- Microsoft.AspNetCore.Components.WebView: from 6.0.0-rc.1.21425.34 to 6.0.0-rc.1.21451.36 (parent: Microsoft.Dotnet.Sdk.Internal)
- Microsoft.AspNetCore.Components.Web: from 6.0.0-rc.1.21425.34 to 6.0.0-rc.1.21451.36 (parent: Microsoft.Dotnet.Sdk.Internal)
- Microsoft.JSInterop: from 6.0.0-rc.1.21425.34 to 6.0.0-rc.1.21451.36 (parent: Microsoft.Dotnet.Sdk.Internal)
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 6.0.0-rc.1.21426.11 to 6.0.0-rc.1.21451.3 (parent: Microsoft.Dotnet.Sdk.Internal)
- System.CodeDom: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13 (parent: Microsoft.AspNetCore.App.Runtime.win-x64)

From https://github.com/xamarin/xamarin-android

Subscription: 1aa7a671-6584-46b0-007b-08d967f5212f
Build: 6.0.1xx-rc1-3793f6e34c40e3aa1a00d0dbe6dd0d706283e197-1
Date Produced: 9/2/2021 7:28 PM
Commit: 3793f6e34c40e3aa1a00d0dbe6dd0d706283e197
Branch: refs/heads/release/6.0.1xx-rc1

Updates:
- Microsoft.Android.Sdk.Windows: from 31.0.100-rc.1.12 to 31.0.100-rc.1.16
- Microsoft.NETCore.App.Ref: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.Dotnet.Sdk.Internal: from 6.0.100-rc.1.21426.23 to 6.0.100-rc.1.21452.4
- Microsoft.Extensions.Primitives: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.AspNetCore.App.Runtime.win-x64: from 6.0.0-rc.1.21425.34 to 6.0.0-rc.1.21451.36
- Microsoft.Extensions.Hosting: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.Extensions.Hosting.Abstractions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.Extensions.DependencyInjection.Abstractions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.Extensions.DependencyInjection: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.Extensions.Configuration.Abstractions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.Extensions.Configuration: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.Extensions.Logging.Abstractions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.Extensions.Logging: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.Extensions.Logging.Console: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.Extensions.Logging.Debug: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.Extensions.FileProviders.Abstractions: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13
- Microsoft.AspNetCore.Authorization: from 6.0.0-rc.1.21425.34 to 6.0.0-rc.1.21451.36
- Microsoft.AspNetCore.Components.WebView: from 6.0.0-rc.1.21425.34 to 6.0.0-rc.1.21451.36
- Microsoft.AspNetCore.Components.Web: from 6.0.0-rc.1.21425.34 to 6.0.0-rc.1.21451.36
- Microsoft.JSInterop: from 6.0.0-rc.1.21425.34 to 6.0.0-rc.1.21451.36
- Microsoft.WindowsDesktop.App.Runtime.win-x64: from 6.0.0-rc.1.21426.11 to 6.0.0-rc.1.21451.3
- System.CodeDom: from 6.0.0-rc.1.21426.8 to 6.0.0-rc.1.21451.13

…uild 6.0.1xx-rc1-3793f6e34c40e3aa1a00d0dbe6dd0d706283e197-1 Microsoft.Android.Sdk.Windows From Version 31.0.100-rc.1.12 -> To Version 31.0.100-rc.1.16 Dependency coherency updates Microsoft.NETCore.App.Ref,Microsoft.Dotnet.Sdk.Internal,Microsoft.Extensions.Primitives,Microsoft.AspNetCore.App.Runtime.win-x64,Microsoft.Extensions.Hosting,Microsoft.Extensions.Hosting.Abstractions,Microsoft.Extensions.DependencyInjection.Abstractions,Microsoft.Extensions.DependencyInjection,Microsoft.Extensions.Configuration.Abstractions,Microsoft.Extensions.Configuration,Microsoft.Extensions.Logging.Abstractions,Microsoft.Extensions.Logging,Microsoft.Extensions.Logging.Console,Microsoft.Extensions.Logging.Debug,Microsoft.Extensions.FileProviders.Abstractions,Microsoft.AspNetCore.Authorization,Microsoft.AspNetCore.Components.WebView,Microsoft.AspNetCore.Components.Web,Microsoft.JSInterop,Microsoft.WindowsDesktop.App.Runtime.win-x64,System.CodeDom From Version 6.0.0-rc.1.21426.8 -> To Version 6.0.0-rc.1.21451.13 (parent: Microsoft.Dotnet.Sdk.Internal

jonathanpeppers · 2021-09-02T20:58:21Z

@Eilon is there maybe a change here for Blazor?

D:\agent\1\s\src\Controls\samples\Controls.Sample.SingleProject\BlazorPage.cs(27,89): error CS0246: The type or namespace name 'Main' could not be found (are you missing a using directive or an assembly reference?)

The only change in xamarin-android here is dotnet bumps.

Eilon · 2021-09-02T22:25:53Z

Well that's weird...

Eilon · 2021-09-02T22:27:09Z

That type is generated by the Razor Source Generator. If for some reason either that type isn't being generated, or is generated at the wrong time or place, then the C# code in BlazorPage.cs won't see it. We've had that happen in WPF where XAML files couldn't see Razor-generated types: dotnet/wpf#4421

But I haven't seen that from regular C# code...

Eilon · 2021-09-02T22:29:12Z

Pinging @captainsafia and @NTaylorMullen in case either of you could think of some reason that a Razor-generated type from Main.razor isn't visible in this C# file BlazorPage.cs. The project file is using the Razor SDK: Maui.Controls.Sample.SingleProject.csproj.

Eilon · 2021-09-02T22:30:22Z

And I should add that I can't think of anything that recently changed that could affect this (famous last words, I know...).

PureWeen · 2021-09-02T22:36:13Z

This all seems to compile fine locally with RC2
Intellisense seems to fail to pick it up but it all compiles.

I queue'd some builds on the public pipeline to see how that goes

Eilon · 2021-09-02T22:49:44Z

So it's not even just this 1 project that's failing. It's the same failure in a few places that C# code is referencing Razor-generated types... but not all of them? (Though maybe it fails too soon to see all of them.)

"D:\a\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample-net6.csproj" (Build target) (5:20) ->
  D:\a\1\s\src\Controls\samples\Controls.Sample\Pages\Others\BlazorPage.xaml.cs(33,89): error CS0246: The type or namespace name 'Main' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample-net6.csproj]
"D:\a\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample-net6.csproj" (Build target) (5:21) ->
  D:\a\1\s\src\Controls\samples\Controls.Sample\Pages\Others\BlazorPage.xaml.cs(33,89): error CS0246: The type or namespace name 'Main' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample-net6.csproj]
"D:\a\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample-net6.csproj" (Build target) (5:22) ->
  D:\a\1\s\src\Controls\samples\Controls.Sample\Pages\Others\BlazorPage.xaml.cs(33,89): error CS0246: The type or namespace name 'Main' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Controls\samples\Controls.Sample\Maui.Controls.Sample-net6.csproj]
"D:\a\1\s\src\BlazorWebView\samples\BlazorWinFormsApp\BlazorWinFormsApp.csproj" (Build target) (23:11) ->
  D:\a\1\s\src\BlazorWebView\samples\BlazorWinFormsApp\Form1.cs(24,47): error CS0246: The type or namespace name 'Main' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\BlazorWebView\samples\BlazorWinFormsApp\BlazorWinFormsApp.csproj]
"D:\a\1\s\src\Controls\samples\Controls.Sample.SingleProject\Maui.Controls.Sample.SingleProject.csproj" (Build target) (43:15) ->
  D:\a\1\s\src\Controls\samples\Controls.Sample.SingleProject\BlazorPage.cs(27,89): error CS0246: The type or namespace name 'Main' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Controls\samples\Controls.Sample.SingleProject\Maui.Controls.Sample.SingleProject.csproj]
"D:\a\1\s\src\Controls\samples\Controls.Sample.SingleProject\Maui.Controls.Sample.SingleProject.csproj" (Build target) (43:16) ->
  D:\a\1\s\src\Controls\samples\Controls.Sample.SingleProject\BlazorPage.cs(27,89): error CS0246: The type or namespace name 'Main' could not be found (are you missing a using directive or an assembly reference?) [D:\a\1\s\src\Controls\samples\Controls.Sample.SingleProject\Maui.Controls.Sample.SingleProject.csproj]
    6 Error(s)

Eilon · 2021-09-02T22:57:38Z

Also weird, it's net6.0 and net6.0-ios that fail. Other platforms (android, windows) seem to compile just fine?

Eilon · 2021-09-02T22:58:10Z

Wait, it's failing in some bizarre cross section of things... not just those platforms.

danroth27 · 2021-09-02T22:58:32Z

@pranavkm @javiercn Any ideas what could be going on here?

Eilon · 2021-09-02T23:05:39Z

In the failing compilations, I see the *.razor files being passed in as AdditionalFiles to the CoreCompile task:

/additionalfile:d:\a\1\s\src\Controls\samples\Controls.Sample.SingleProject\Main.razor
/additionalfile:d:\a\1\s\src\Controls\samples\Controls.Sample.SingleProject\Pages\Index.razor
/additionalfile:d:\a\1\s\src\Controls\samples\Controls.Sample.SingleProject\_Imports.razor

I assume that's correct for Razor Source Generator?

It's passing in these analyzers:

/analyzer:D:\a\1\s\bin\dotnet\sdk\6.0.100-rc.1.21452.4\Sdks\Microsoft.NET.Sdk.Razor\targets\..\\source-generators\Microsoft.AspNetCore.Razor.Internal.SourceGenerator.Transport.dll 
/analyzer:D:\a\1\s\bin\dotnet\sdk\6.0.100-rc.1.21452.4\Sdks\Microsoft.NET.Sdk.Razor\targets\..\\source-generators\Microsoft.NET.Sdk.Razor.SourceGenerators.dll

pranavkm · 2021-09-02T23:10:12Z

I think it's because you're explicitly configuring a LangVersion -

maui/src/Controls/samples/Controls.Sample.iOS/Controls.Sample.iOS.csproj

Line 4 in cadf547

. The incremental source generator requires C# 10 or newer.

Eilon · 2021-09-02T23:14:30Z

Ah! OK we can try to change that.... hopefully it doesn't break anything. Is 10 the default? Should we just remove LangVersion?

Eilon · 2021-09-02T23:16:18Z

Interestingly, there's only a few places we explicitly set 9.0. Everything else is either not set or default or preview

Eilon · 2021-09-02T23:20:23Z

But also it seems some of the projects don't set that. Having LangVersion=9.0 in Controls.Sample.iOS.csproj might explain why Controls.Sample\Pages\Others\BlazorPage.xaml.cs isn't working (it's referenced by it), but it doesn't seem to explain the error in SingleProject, which doesn't seem to have LangVersion=9.0 anywhere in its tree (except for random other projects it indirectly references?).

Razor Source Generator needs at least 10.0

Eilon · 2021-09-02T23:21:46Z

Either way, I pushed e2ba46a so we'll see what happens...

Eilon · 2021-09-02T23:27:46Z

Also, one of the specific compilations that failed also had this command line arg in the failing step: /langversion:latest ...

Eilon · 2021-09-02T23:32:28Z

In fact, nowhere in this compilation do I see anything other than LangVersion=10.0.

However, there are suspiciously some places where I see RazorLangVersion=2.1 (though they are mostly 6.0), even though it's not explicitly set anywhere in the repo.

Eilon · 2021-09-02T23:33:30Z

Hmm... I wonder if maybe something is trying to use .NET 6 stuff on .NET 5?? I know some projects target older .NET's... and maybe they're "accidentally" getting mixed up in some bad business??

Eilon · 2021-09-02T23:34:06Z

Even though the TFM in question here is always net6.0 or net6.0-something...

Redth · 2021-09-02T23:38:39Z

@Eilon there's a few other spots I'm seeing it set...

maui/src/BlazorWebView/src/Maui/Microsoft.AspNetCore.Components.WebView.Maui.csproj

Line 5 in 50999f6

maui/eng/Environment.Build.props

Line 31 in f0e8ea7

<LangVersion>latest</LangVersion>

maui/src/Essentials/src/Essentials.csproj

Line 7 in 65a4499

maui/src/SingleProject/Resizetizer/src/Resizetizer.csproj

Line 8 in 57bf069

One of those is 'latest' but I also see others as 'preview', perhaps 'latest' still == 9.0 at this point?

Eilon · 2021-09-02T23:39:45Z

Hmm OK maybe latest=9.0 because preview=10.0? That's believable.

Redth · 2021-09-02T23:42:08Z

There's others that are preview too in the repo still

Eilon · 2021-09-02T23:42:11Z

Also interestingly, according to https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/configure-language-version#defaults, if you use net6 then you get 10.0 by default....

Eilon · 2021-09-02T23:43:38Z

OK I pushed <LangVersion>10.0</LangVersion> to some projects/targets. I didn't want to muck with some seemingly totally unrelated projects as part of this Maestro change. We can try that in a separate change if this one here works.

Eilon · 2021-09-02T23:43:50Z

Also, time to go pick up kids. I will check on this later tonight.

Context: dotnet/sdk@10efeed...454eae3 This was removed from the dotnet/sdk:  <LangVersion Condition="'$(UseRazorSourceGenerator)' != '' ">preview</LangVersion> So I think we need to opt into `preview` to build with the older Roslyn in VS.

jonathanpeppers · 2021-09-03T02:01:41Z

I was looking at the diff of the dotnet/sdk in this bump:

dotnet/sdk@10efeed...454eae3

-        <!-- Required to support incremental source generator -->
-        <LangVersion Condition="'$(UseRazorSourceGenerator)' != '' ">preview</LangVersion>

dotnet/maui has to build with VS/.NET framework MSBuild to support WinUI (WinUI's MSBuild task assemblies are still .NET framework).

I bet the VS we're building with doesn't have the latest Roslyn, and so LangVersion=preview must be needed.

eng\Environment.Build.props appears to be the place this value is needed from looking at the .binlog. I pushed a commit with this change.

jonathanpeppers · 2021-09-03T02:05:29Z

The other error I'm seeing (didn't fix yet):

/Users/builder/azdo/_work/1/s/src/Controls/tests/Core.UnitTests/TypedBindingUnitTests.cs(1355,11): error CS0121: The call is ambiguous between the following methods or properties: 'Assert.That(TestDelegate, IResolveConstraint)' and 'Assert.That<TActual>(TActual, IResolveConstraint)' [/Users/builder/azdo/_work/1/s/src/Controls/tests/Core.UnitTests/Controls.Core.UnitTests-net6.csproj]

There is a change to overload resolution in the diff:

dotnet/roslyn@4b95718

The projects hitting this (a couple test projects), we might need to keep them on C# 9 and put a comment why.

This apparently breaks NUnit `Assert.That()` calls. I could build the project locally after this change.

jonathanpeppers · 2021-09-03T02:57:01Z

Ok, just seems like test failures now:

@Redth I don't know if we've seen those before?

Eilon · 2021-09-03T03:07:02Z

It's conceivable that these test failures have something to do with the MauiAppBuilder stuff I did recently for Startup. Though I'm not sure why they would start failing here. It's possible we were accidentally dependent on some behavior that changes recently from MS.Extensions.DI or something like that. (Or it could be totally unrelated.) I'll investigate tonight.

Eilon · 2021-09-03T04:25:33Z

The tests all pass locally...

Eilon · 2021-09-03T04:54:02Z

And I just realized they failed on Mac only. They passed on Windows.

Eilon · 2021-09-03T05:04:46Z

I'm testing my hypothesis that this has to do with whether the platform supports dynamic compiled code, per RuntimeFeature.IsDynamicCodeCompiled. DI implementation is quite different depending on this property, and there can be bugs in one mode vs. the other, which could explain one platform failing and another not.

Eilon · 2021-09-03T05:28:17Z

Well that's no fun, all platforms (Windows and macOS) report RuntimeFeature.IsDynamicCodeCompiled = True. I'm at a loss here...

Eilon · 2021-09-03T05:30:58Z

I reverted and forced push to before my silly test.

Eilon · 2021-09-03T06:55:09Z

OK it does fail locally on my Mac, so that's something to look at.

This reverts commit 85ce42d.

I think we might also be hitting some method overloading issues in these test failures: * `CanAddMultipleEventsViaMultipleConfigureLifecycleEvents` * `CanAddMultipleEventsViaBuilder` * `EventsFireExactlyOnce`

This reverts commit 90c233d.

This solves 3 test failures: > .\bin\dotnet\dotnet.exe test src\Core\tests\UnitTests\Core.UnitTests-net6.csproj -bl ... [xUnit.net 00:00:00.60] CanAddMultipleEventsViaMultipleConfigureLifecycleEvents [FAIL] Failed CanAddMultipleEventsViaMultipleConfigureLifecycleEvents [10 ms] Error Message: Assert.Equal() Failure Expected: 1 Actual: 0 Stack Trace: at Microsoft.Maui.UnitTests.LifecycleEvents.LifecycleEventsTests.CanAddMultipleEventsViaMultipleConfigureLifecycleEvents() in C:\src\maui\src\Core\tests\UnitTests\LifecycleEvents\LifecycleEventsTests.cs:line 134 [xUnit.net 00:00:00.62] EventsFireExactlyOnce [FAIL] [xUnit.net 00:00:00.62] CanAddMultipleEventsViaBuilder [FAIL] Failed EventsFireExactlyOnce [2 ms] Error Message: Assert.Equal() Failure Expected: 1 Actual: 0 Stack Trace: at Microsoft.Maui.UnitTests.LifecycleEvents.LifecycleEventsTests.EventsFireExactlyOnce() in C:\src\maui\src\Core\tests\UnitTests\LifecycleEvents\LifecycleEventsTests.cs:line 75 Failed CanAddMultipleEventsViaBuilder [2 ms] Error Message: Assert.Equal() Failure Expected: 1 Actual: 0 Stack Trace: at Microsoft.Maui.UnitTests.LifecycleEvents.LifecycleEventsTests.CanAddMultipleEventsViaBuilder() in C:\src\maui\src\Core\tests\UnitTests\LifecycleEvents\LifecycleEventsTests.cs:line 156 Failed! - Failed: 3, Passed: 367, Skipped: 0, Total: 370, Duration: 192 ms - Microsoft.Maui.UnitTests.dll (net6.0)

…50e4-1860-4e4e-88b6-076f82a5d302

Eilon · 2021-09-03T16:26:09Z

So what exactly "fixed" this? Did we just wait for a newer Roslyn that fixed/changed what was originally breaking this test?

jonathanpeppers · 2021-09-03T16:35:24Z

So what exactly "fixed" this? Did we just wait for a newer Roslyn that fixed/changed what was originally breaking this test?

@Eilon I think there were two issues:

Blazor needs LangVersion=preview when building with the version of VS 2022 the CI machines have. I think they just have the latest public preview.
dotnet/maui unit tests saw various changes in method overload behavior that went away with LangVersion=9.0. Filed this here: .NET 6 RC 1: changes to overload resolution? Breaks NUnit? roslyn#56167

* upstream/main: (326 commits) Re-enable interpreter on blazor by default Determine size of auto cells in GridLayout correctly when views occupy same cell (dotnet#2391) [main] Update dependencies from xamarin/xamarin-macios (dotnet#2326) [Android] Fix Horizontal Scrollbar Visibility (dotnet#2374) Try start vs4mac with local dotnet (dotnet#2386) [workoad] include missing dependencies in the workload (dotnet#2281) Update project templates to work with safe characters (dotnet#2368) [release/6.0.1xx-rc1] Update dependencies from xamarin/xamarin-android (dotnet#2369) Update dependencies from https://github.com/xamarin/xamarin-macios build 20210903.3 (dotnet#2384) Bump manifest to use api 31 (dotnet#2366) BoxView Handlers (dotnet#2250) Implement IsTextPredictionEnabled in WinUI Editor (dotnet#1478) Implement PlaceholderColor property in EntryHandlers (dotnet#1513) Automated dotnet-format update (dotnet#2355) Show entire search bar by default and make it not collapse (dotnet#2351) Remove test cloud if def for now (dotnet#2350) Add support for JS root components in BlazorWebView (dotnet#2293) Set base viewmapper to work against IViewHandler (dotnet#2339) NavigationView Handler for Android (dotnet#2336) Update OutputType to WinExe on -windows (dotnet#2340) ...

Remove incorrect LangVersion 9.0 and use default

e2ba46a

Razor Source Generator needs at least 10.0

dotnet-maestro bot requested a review from Eilon as a code owner September 2, 2021 23:21

Explicitly set LangVersion=10.0

b29e195

Keep Controls.Core.UnitTests on C# 9

47de1f3

This apparently breaks NUnit `Assert.That()` calls. I could build the project locally after this change.

Eilon force-pushed the darc-release/6.0.1xx-rc1-cd9950e4-1860-4e4e-88b6-076f82a5d302 branch from a39e866 to 47de1f3 Compare September 3, 2021 05:30

rmarinho and others added 5 commits September 3, 2021 12:47

Try start vs4mac with local dotnet

85ce42d

Revert "Try start vs4mac with local dotnet"

989bc16

This reverts commit 85ce42d.

Update LifecycleEventsTests.cs

90c233d

I think we might also be hitting some method overloading issues in these test failures: * `CanAddMultipleEventsViaMultipleConfigureLifecycleEvents` * `CanAddMultipleEventsViaBuilder` * `EventsFireExactlyOnce`

Revert "Update LifecycleEventsTests.cs"

48f708d

This reverts commit 90c233d.

jonathanpeppers mentioned this pull request Sep 3, 2021

.NET 6 RC 1: changes to overload resolution? Breaks NUnit? dotnet/roslyn#56167

Closed

Merge branch 'release/6.0.1xx-rc1' into darc-release/6.0.1xx-rc1-cd99…

85b3313

…50e4-1860-4e4e-88b6-076f82a5d302

Redth approved these changes Sep 3, 2021

View reviewed changes

jonathanpeppers approved these changes Sep 3, 2021

View reviewed changes

Redth merged commit 294dff1 into release/6.0.1xx-rc1 Sep 3, 2021

Redth deleted the darc-release/6.0.1xx-rc1-cd9950e4-1860-4e4e-88b6-076f82a5d302 branch September 3, 2021 16:39

Eilon added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Sep 30, 2021

github-actions bot locked and limited conversation to collaborators Dec 25, 2023

samhouts added the fixed-in-6.0.100-rc.1.7 Look for this fix in 6.0.100-rc.1.7! label Aug 2, 2024

Conversation

dotnet-maestro bot commented Sep 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coherency Updates

From https://github.com/xamarin/xamarin-android

Uh oh!

jonathanpeppers commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

PureWeen commented Sep 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danroth27 commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

pranavkm commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Redth commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Redth commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

Eilon commented Sep 2, 2021

Uh oh!

jonathanpeppers commented Sep 3, 2021

Uh oh!

jonathanpeppers commented Sep 3, 2021

Uh oh!

jonathanpeppers commented Sep 3, 2021

Uh oh!

Eilon commented Sep 3, 2021

Uh oh!

Eilon commented Sep 3, 2021

Uh oh!

Eilon commented Sep 3, 2021

Uh oh!

Eilon commented Sep 3, 2021

Uh oh!

Eilon commented Sep 3, 2021

Uh oh!

Eilon commented Sep 3, 2021

Uh oh!

Eilon commented Sep 3, 2021

dotnet-maestro bot commented Sep 2, 2021 •

edited

Loading

Eilon commented Sep 2, 2021 •

edited

Loading

PureWeen commented Sep 2, 2021 •

edited

Loading

Eilon commented Sep 2, 2021 •

edited

Loading