Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Merge nmirror to master#3262

Merged
jkotas merged 12 commits intomasterfrom
nmirror
Apr 7, 2017
Merged

Merge nmirror to master#3262
jkotas merged 12 commits intomasterfrom
nmirror

Conversation

@jkotas
Copy link
Member

@jkotas jkotas commented Apr 7, 2017

No description provided.

dotnet-bot and others added 11 commits April 7, 2017 09:15
     The class lib functions are already hooked up to code manager. However, there are cases where we look for class lib functions from EEtype, such as GetClasslibException on an eeype. This change attaches the class lib function array to every type manager and sets up a runtime helper to get to the class lib function GetRuntimeException from an EEtype.

[tfs-changeset: 1653592]
Added github comments to NotImplementedExceptions (that I know about)
and removed a few false-positive NotImplementationException calls.
[tfs-changeset: 1653620]
Make EventSource.EventMetadata and EventDescriptor public so that analysis roots them.

     These types were public in the separate System.Diagnostics.Tracing assembly, now the move to CoreLib marked them as private.
     While they are technically private (it's a contract used between the library and the ILC toolchain), we need them to be rooted and exported from shared library for the system to work.

     For now I'm simply marking them as public again.
     A cleaner solution might be to use .rd.xml to root them and modify shared library definition to force export them.

[tfs-changeset: 1653635]
--Implement GetRuntimeLookupSignatureNameForClass/GetRuntimeLookupSignatureNameForMethod in bridge code

--GetRuntimeLookupSignatureNameForMethod is used for all usg lookups, regardless of whether method is generic/nongeneric.  In the case of a nongeneric method, I do lookup using TypeDesc instead of MethodDesc.

--Call these from jitinterface instead of the stub code.

--Made method NativeLayoutSignature public so its callable from the bridge

--Made class NativeLayoutSignatureNode public as method NativeLayoutSignature is now public

--Merged method signature and type signature hashtables into a single hashtable GlobalNameLookUpSignatureMap
----This lets us avoid creating multiple SSRs for identical types
----This is a possible perf hit since we're indexing on char* now instead of handles - there are a couple options in the future to mitigate this

[tfs-changeset: 1653636]
- String.GetHashCode() now uses Marvin unconditionally.

- Make the Marvin routines more general purpose and
  easier to use.

- Expanded the testing to odd-sized byte arrays (i.e.
  not strings), and fixed the bug found. Original
  data obtained by exporting SymCryptMarvin32() from
  CoreClr.dll and P/Invoking to it from test app.
@jkotas jkotas merged commit 87e5883 into master Apr 7, 2017
dotnet-bot pushed a commit to dotnet/coreclr that referenced this pull request Apr 7, 2017
Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
jkotas added a commit to dotnet/coreclr that referenced this pull request Apr 8, 2017
Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
dotnet-bot pushed a commit to dotnet/corefx that referenced this pull request Jan 13, 2018
Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
dotnet-bot pushed a commit to dotnet/corefx that referenced this pull request Jan 13, 2018
Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern pushed a commit to dotnet/corefx that referenced this pull request Jan 16, 2018
Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
safern pushed a commit to dotnet/corefx that referenced this pull request Jan 16, 2018
Merge nmirror to master

Signed-off-by: dotnet-bot <dotnet-bot@microsoft.com>
Signed-off-by: dotnet-bot-corefx-mirror <dotnet-bot@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants