Skip to content
This repository was archived by the owner on Nov 1, 2020. It is now read-only.

Merge changes from TFS#3260

Merged
jkotas merged 1 commit intodotnet:nmirrorfrom
dotnet-bot:from-tfs
Apr 7, 2017
Merged

Merge changes from TFS#3260
jkotas merged 1 commit intodotnet:nmirrorfrom
dotnet-bot:from-tfs

Conversation

@dotnet-bot
Copy link
Collaborator

No description provided.

Make EventSource.EventMetadata and EventDescriptor public so that analysis roots them.

     These types were public in the separate System.Diagnostics.Tracing assembly, now the move to CoreLib marked them as private.
     While they are technically private (it's a contract used between the library and the ILC toolchain), we need them to be rooted and exported from shared library for the system to work.

     For now I'm simply marking them as public again.
     A cleaner solution might be to use .rd.xml to root them and modify shared library definition to force export them.

[tfs-changeset: 1653635]
@jkotas jkotas merged commit 51b03b5 into dotnet:nmirror Apr 7, 2017
@dotnet-bot dotnet-bot deleted the from-tfs branch April 7, 2017 20:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants