This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Incorporate CR feedback on Marvin hash#3263
Merged
1 commit merged intonmirrorfrom Apr 7, 2017
unknown repository
Merged
Conversation
- String.GetHashCode() now uses Marvin unconditionally. - Make the Marvin routines more general purpose and easier to use. - Expanded the testing to odd-sized byte arrays (i.e. not strings), and fixed the bug found. Original data obtained by exporting SymCryptMarvin32() from CoreClr.dll and P/Invoking to it from test app.
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String.GetHashCode() now uses Marvin unconditionally.
Make the Marvin routines more general purpose and
easier to use.
Expanded the testing to odd-sized byte arrays (i.e.
not strings), and fixed the bug found. Original
data obtained by exporting SymCryptMarvin32() from
CoreClr.dll and P/Invoking to it from test app.