This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merged
Conversation
--Implement GetRuntimeLookupSignatureNameForClass/GetRuntimeLookupSignatureNameForMethod in bridge code --GetRuntimeLookupSignatureNameForMethod is used for all usg lookups, regardless of whether method is generic/nongeneric. In the case of a nongeneric method, I do lookup using TypeDesc instead of MethodDesc. --Call these from jitinterface instead of the stub code. --Made method NativeLayoutSignature public so its callable from the bridge --Made class NativeLayoutSignatureNode public as method NativeLayoutSignature is now public --Merged method signature and type signature hashtables into a single hashtable GlobalNameLookUpSignatureMap ----This lets us avoid creating multiple SSRs for identical types ----This is a possible perf hit since we're indexing on char* now instead of handles - there are a couple options in the future to mitigate this [tfs-changeset: 1653636]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.