Merged
Conversation
Member
|
@alecslupu this is ready to be reviewed? |
Contributor
Author
@andreslucena yes, you can look at it |
andreslucena
requested changes
Oct 20, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Thanks for the PR, its no longer in the UI 👏🏽 👏🏽
I found out a couple more places to remove it:
https://github.com/decidim/decidim/blob/develop/decidim-core/config/locales/en.yml?plain=1#L892
https://github.com/decidim/decidim/blob/develop/decidim-core/app/packs/images/decidim/gamification/badges/decidim_gamification_badges_invitations.svg
Can you remove them 🙏🏽 ? Thanks
aa03b3f to
72dcc46
Compare
andreslucena
approved these changes
Oct 25, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
LGTM 👍🏽
Only failing spec is unrelated to this PR. It's from codeclimate (fixed at #9910)
This was referenced Oct 26, 2022
entantoencuanto
added a commit
that referenced
this pull request
Oct 26, 2022
* develop: (35 commits) Install turbo-rails (#9881) Fix conference invitations (#9664) Fix invalid rendering of meeting and proposal body texts (#9764) Make documentation site work with multiple versions (#9917) Bump versions on install docs (#9916) Standardize CSV import formats and fix private users CSV import with invalid file (#9627) Fix: The i18n locales selector is showing a dropdown with 3 languages (#9902) Make Scopes field in debates translatable (#9903) Make ToS agreement translatable (#9909) Fix issues with a11y specs (#9929) Remove invitations badge (#9906) Make initiatives order translatable (#9905) Add missing active actions on admin navigation menu (#9904) Fix user sign up with invalid name (#9896) Remove duplication of LastActivity queries (#9895) Rename IgnoredMethods to AllowedMethods in Rubocop configuration (#9893) Exclude malformed file from codeclimate configuration (#9910) Fix correct resource linking for amendments (#9887) Fix superposition in admin's error forms (#9871) Add missing i18n key in Initiatives (#9892) ...
entantoencuanto
added a commit
that referenced
this pull request
Oct 31, 2022
* develop: (36 commits) Fix proposal etiquette and length validator with base64 images (#9639) Install turbo-rails (#9881) Fix conference invitations (#9664) Fix invalid rendering of meeting and proposal body texts (#9764) Make documentation site work with multiple versions (#9917) Bump versions on install docs (#9916) Standardize CSV import formats and fix private users CSV import with invalid file (#9627) Fix: The i18n locales selector is showing a dropdown with 3 languages (#9902) Make Scopes field in debates translatable (#9903) Make ToS agreement translatable (#9909) Fix issues with a11y specs (#9929) Remove invitations badge (#9906) Make initiatives order translatable (#9905) Add missing active actions on admin navigation menu (#9904) Fix user sign up with invalid name (#9896) Remove duplication of LastActivity queries (#9895) Rename IgnoredMethods to AllowedMethods in Rubocop configuration (#9893) Exclude malformed file from codeclimate configuration (#9910) Fix correct resource linking for amendments (#9887) Fix superposition in admin's error forms (#9871) ...
Quentinchampenois
pushed a commit
to Quentinchampenois/decidim
that referenced
this pull request
Nov 23, 2022
* Remove invites badge * Implement review recommendations
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR is removing the badge
📌 Related Issues
Link your PR to an issue
Testing
Describe the best way to test or validate your PR.
📷 Screenshots
Please add screenshots of the changes you're proposing
