Fix invalid rendering of meeting and proposal body texts#9764
Merged
andreslucena merged 10 commits intodecidim:developfrom Oct 26, 2022
Merged
Fix invalid rendering of meeting and proposal body texts#9764andreslucena merged 10 commits intodecidim:developfrom
andreslucena merged 10 commits intodecidim:developfrom
Conversation
Member
|
Code wise, everything looks 👌🏽 Just a minor change. With this text:
Before it was rendered like this (with the bug):
With this PR:
I think we should add some padding at the bottom (with CSS or however you prefer). Can you do that please? |
andreslucena
requested changes
Sep 23, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
I've left a comment with a minor change, can you check it out whenever you have time? Thanks
Contributor
Author
|
Displayed list styles should be now fixed with the latest commits. I also added a margin bottom to the lists when in editor because it bothers me (and some other editors judging that they add extra paragraphs) that the next paragraph is attached to the list above it. While doing this (and merging with develop), I noticed we've broken the sub-lists when re-editing the lists. Reported that as a separate issue at #9866. It does not seem to be related to this PR. |
Member
|
There are some broken related specs, can you check them out @ahukkanen 🙏🏽? |
andreslucena
requested changes
Sep 30, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Can you check out the failing specs 🙏🏽? Also, you'll need to merge with develop to fix the one failing from assemblies. Thanks
Contributor
Author
|
Done @andreslucena |
andreslucena
reviewed
Oct 6, 2022
andreslucena
requested changes
Oct 6, 2022
Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
entantoencuanto
added a commit
that referenced
this pull request
Oct 26, 2022
* develop: (35 commits) Install turbo-rails (#9881) Fix conference invitations (#9664) Fix invalid rendering of meeting and proposal body texts (#9764) Make documentation site work with multiple versions (#9917) Bump versions on install docs (#9916) Standardize CSV import formats and fix private users CSV import with invalid file (#9627) Fix: The i18n locales selector is showing a dropdown with 3 languages (#9902) Make Scopes field in debates translatable (#9903) Make ToS agreement translatable (#9909) Fix issues with a11y specs (#9929) Remove invitations badge (#9906) Make initiatives order translatable (#9905) Add missing active actions on admin navigation menu (#9904) Fix user sign up with invalid name (#9896) Remove duplication of LastActivity queries (#9895) Rename IgnoredMethods to AllowedMethods in Rubocop configuration (#9893) Exclude malformed file from codeclimate configuration (#9910) Fix correct resource linking for amendments (#9887) Fix superposition in admin's error forms (#9871) Add missing i18n key in Initiatives (#9892) ...
entantoencuanto
added a commit
that referenced
this pull request
Oct 31, 2022
* develop: (36 commits) Fix proposal etiquette and length validator with base64 images (#9639) Install turbo-rails (#9881) Fix conference invitations (#9664) Fix invalid rendering of meeting and proposal body texts (#9764) Make documentation site work with multiple versions (#9917) Bump versions on install docs (#9916) Standardize CSV import formats and fix private users CSV import with invalid file (#9627) Fix: The i18n locales selector is showing a dropdown with 3 languages (#9902) Make Scopes field in debates translatable (#9903) Make ToS agreement translatable (#9909) Fix issues with a11y specs (#9929) Remove invitations badge (#9906) Make initiatives order translatable (#9905) Add missing active actions on admin navigation menu (#9904) Fix user sign up with invalid name (#9896) Remove duplication of LastActivity queries (#9895) Rename IgnoredMethods to AllowedMethods in Rubocop configuration (#9893) Exclude malformed file from codeclimate configuration (#9910) Fix correct resource linking for amendments (#9887) Fix superposition in admin's error forms (#9871) ...
Quentinchampenois
pushed a commit
to Quentinchampenois/decidim
that referenced
this pull request
Nov 23, 2022
* Remove the double sanitization from the meeting description * Fix the rendering of the safe content * Add proper styles for the quill lists * Fix rich text editor specs after class name change * Revert the edit spec change which was already correct * Fix typos in specs Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com> * Remove ql-reset-decidim class Co-authored-by: Andrés Pereira de Lucena <andreslucena@users.noreply.github.com>
This was referenced Apr 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Currently meeting and proposal body rendering can be broken as explained at #9763. This fixes the described issue.
📌 Related Issues
Testing
<br>tags within the meeting description list