Fix conference invitations#9664
Merged
andreslucena merged 12 commits intodecidim:developfrom Oct 26, 2022
Merged
Conversation
lawrencemcn
reviewed
Aug 25, 2022
decidim-conferences/app/commands/decidim/conferences/admin/invite_user_to_join_conference.rb
Show resolved
Hide resolved
Member
|
About the two issues: a) New/Non existing participants (#9371). I can confirm that this is solved.
ActiveRecord::RecordInvalid (Validation failed: User has already been taken):
activerecord (6.1.6) lib/active_record/validations.rb:80:in `raise_validation_error'
activerecord (6.1.6) lib/active_record/validations.rb:53:in `save!'
activerecord (6.1.6) lib/active_record/transactions.rb:302:in `block in save!'
activerecord (6.1.6) lib/active_record/transactions.rb:354:in `block in with_transaction_returning_status'
activerecord (6.1.6) lib/active_record/connection_adapters/abstract/database_statements.rb:318:in `transaction'
activerecord (6.1.6) lib/active_record/transactions.rb:350:in `with_transaction_returning_status'
activerecord (6.1.6) lib/active_record/transactions.rb:302:in `save!'
activerecord (6.1.6) lib/active_record/suppressor.rb:48:in `save!'
activerecord (6.1.6) lib/active_record/persistence.rb:55:in `create!'
/home/apereira/Work/decidim/decidim/decidim-conferences/app/commands/decidim/conferences/join_conference.rb:45:in `create_registration'
/home/apereira/Work/decidim/decidim/decidim-conferences/app/commands/decidim/conferences/join_conference.rb:26:in `block in call'We should check out if the invitation was accepted before acceptance. Can you check that out @ahukkanen 🙏🏽 ? Thanks |
Member
|
Uops, wrong button, sorry 😅 |
andreslucena
requested changes
Oct 10, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Please see my last comment, I think we'd need to fix that (and also add an spec for that)
In case the user already joined the conference, broadcast ok.
Contributor
Author
|
@andreslucena Fixed the remaining issue. |
andreslucena
requested changes
Oct 26, 2022
Member
andreslucena
left a comment
There was a problem hiding this comment.
Just a detail regarding a i18n string and we're good to go!
decidim-conferences/app/views/devise/mailer/join_conference.text.erb
Outdated
Show resolved
Hide resolved
This was referenced Oct 26, 2022
entantoencuanto
added a commit
that referenced
this pull request
Oct 26, 2022
* develop: (35 commits) Install turbo-rails (#9881) Fix conference invitations (#9664) Fix invalid rendering of meeting and proposal body texts (#9764) Make documentation site work with multiple versions (#9917) Bump versions on install docs (#9916) Standardize CSV import formats and fix private users CSV import with invalid file (#9627) Fix: The i18n locales selector is showing a dropdown with 3 languages (#9902) Make Scopes field in debates translatable (#9903) Make ToS agreement translatable (#9909) Fix issues with a11y specs (#9929) Remove invitations badge (#9906) Make initiatives order translatable (#9905) Add missing active actions on admin navigation menu (#9904) Fix user sign up with invalid name (#9896) Remove duplication of LastActivity queries (#9895) Rename IgnoredMethods to AllowedMethods in Rubocop configuration (#9893) Exclude malformed file from codeclimate configuration (#9910) Fix correct resource linking for amendments (#9887) Fix superposition in admin's error forms (#9871) Add missing i18n key in Initiatives (#9892) ...
entantoencuanto
added a commit
that referenced
this pull request
Oct 31, 2022
* develop: (36 commits) Fix proposal etiquette and length validator with base64 images (#9639) Install turbo-rails (#9881) Fix conference invitations (#9664) Fix invalid rendering of meeting and proposal body texts (#9764) Make documentation site work with multiple versions (#9917) Bump versions on install docs (#9916) Standardize CSV import formats and fix private users CSV import with invalid file (#9627) Fix: The i18n locales selector is showing a dropdown with 3 languages (#9902) Make Scopes field in debates translatable (#9903) Make ToS agreement translatable (#9909) Fix issues with a11y specs (#9929) Remove invitations badge (#9906) Make initiatives order translatable (#9905) Add missing active actions on admin navigation menu (#9904) Fix user sign up with invalid name (#9896) Remove duplication of LastActivity queries (#9895) Rename IgnoredMethods to AllowedMethods in Rubocop configuration (#9893) Exclude malformed file from codeclimate configuration (#9910) Fix correct resource linking for amendments (#9887) Fix superposition in admin's error forms (#9871) ...
Quentinchampenois
pushed a commit
to Quentinchampenois/decidim
that referenced
this pull request
Nov 23, 2022
* Fix conference invitations * Clarify the unauthorized errors when accepting/rejecting conference invitation * Fix redirecting back to the same URL (accept/reject) after sign in * Clarify the conference invitation text when inviting a new user * Fix decline conference invitation link * Add spaces to the links * Fix re-joining already joined conference In case the user already joined the conference, broadcast ok. * Change the i18n key for invite existing users
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
The conference invitations are broken for non-participants and partially broken for participants as explained at #9371 and #9378.
This fixes both of those issues.
📌 Related Issues
Testing
Existing participants
user@example.organd send an invitation to themNew participants