Conversation
6d8539d to
3071925
Compare
ferblape
reviewed
Oct 19, 2022
ferblape
reviewed
Oct 19, 2022
ferblape
reviewed
Oct 19, 2022
43ec8b5 to
59421b8
Compare
Contributor
|
Since the last commit (about what I mentioned in today's meeting) is a very likely source of git conflicts, I'd like to merge it asap 🙏 taking preference over other PRs |
Crashillo
previously approved these changes
Oct 20, 2022
Contributor
|
ping @ahukkanen |
0133461 to
b3f8880
Compare
ahukkanen
requested changes
Oct 25, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
I see one potential problem on how the initializer() method is implemented for the page, if you could take a look?
I'd like to solve this kind of issue as early as possible as this tends to cause bugs somewhere else along the line. The system tests may not notice such issues easily as most of them are reloading the whole view when the test starts.
ahukkanen
requested changes
Oct 25, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
This makes the comments spec flaky even with the added sleep.
Please see below how to fix it.
decidim-core/lib/decidim/core/test/shared_examples/comments_examples.rb
Outdated
Show resolved
Hide resolved
entantoencuanto
added a commit
that referenced
this pull request
Oct 26, 2022
* develop: (35 commits) Install turbo-rails (#9881) Fix conference invitations (#9664) Fix invalid rendering of meeting and proposal body texts (#9764) Make documentation site work with multiple versions (#9917) Bump versions on install docs (#9916) Standardize CSV import formats and fix private users CSV import with invalid file (#9627) Fix: The i18n locales selector is showing a dropdown with 3 languages (#9902) Make Scopes field in debates translatable (#9903) Make ToS agreement translatable (#9909) Fix issues with a11y specs (#9929) Remove invitations badge (#9906) Make initiatives order translatable (#9905) Add missing active actions on admin navigation menu (#9904) Fix user sign up with invalid name (#9896) Remove duplication of LastActivity queries (#9895) Rename IgnoredMethods to AllowedMethods in Rubocop configuration (#9893) Exclude malformed file from codeclimate configuration (#9910) Fix correct resource linking for amendments (#9887) Fix superposition in admin's error forms (#9871) Add missing i18n key in Initiatives (#9892) ...
entantoencuanto
added a commit
that referenced
this pull request
Oct 31, 2022
* develop: (36 commits) Fix proposal etiquette and length validator with base64 images (#9639) Install turbo-rails (#9881) Fix conference invitations (#9664) Fix invalid rendering of meeting and proposal body texts (#9764) Make documentation site work with multiple versions (#9917) Bump versions on install docs (#9916) Standardize CSV import formats and fix private users CSV import with invalid file (#9627) Fix: The i18n locales selector is showing a dropdown with 3 languages (#9902) Make Scopes field in debates translatable (#9903) Make ToS agreement translatable (#9909) Fix issues with a11y specs (#9929) Remove invitations badge (#9906) Make initiatives order translatable (#9905) Add missing active actions on admin navigation menu (#9904) Fix user sign up with invalid name (#9896) Remove duplication of LastActivity queries (#9895) Rename IgnoredMethods to AllowedMethods in Rubocop configuration (#9893) Exclude malformed file from codeclimate configuration (#9910) Fix correct resource linking for amendments (#9887) Fix superposition in admin's error forms (#9871) ...
Quentinchampenois
pushed a commit
to Quentinchampenois/decidim
that referenced
this pull request
Nov 23, 2022
* Install turbo-rails * Add install turbo task to decidim:webpacker:install * Fix turbo dependencies * Update package-lock files and synchronize app design files * Update package-lock files and synchronize app design files including turbo * Reorder turbo installation task and remove yarn files after that * Reorder turbo import * Reorder js imports in decidim_core entrypoint * Initialize character counter on turbo:load event * Use initializer only with turbo events * Ensure initializer is called once * Reorder imports * Move turbo-rails dependency to core * Fix external_link initialization in legacy design index.js * Fix selector in test * Force flaky test * rearrangement frontend libraries * legacy index (from develop) * move all the comments initializations to its own gem Co-authored-by: Hugoren Martinako <aumpfbahn@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
This PR adds the turbo-rails dependencies to Decidim