Do not send upcoming meeting notification for hidden or withdrawn meetings#9134
Merged
ahukkanen merged 2 commits intodecidim:developfrom Apr 6, 2022
Merged
Conversation
ahukkanen
previously approved these changes
Apr 4, 2022
Contributor
ahukkanen
left a comment
There was a problem hiding this comment.
LGTM 👍
I'll let @alecslupu also have a look as he's marked as a reviewer.
alecslupu
reviewed
Apr 4, 2022
decidim-meetings/app/jobs/decidim/meetings/upcoming_meeting_notification_job.rb
Show resolved
Hide resolved
Contributor
@ahukkanen I have added my comment, regarding my doubts. if you do not agree with my assessment, Please feel free to merge. |
alecslupu
approved these changes
Apr 5, 2022
ahukkanen
approved these changes
Apr 5, 2022
entantoencuanto
added a commit
to PopulateTools/decidim
that referenced
this pull request
Apr 6, 2022
…into pwa-staging * chore/cache_highligted_resources_for_components_cells: Define expiry_time on highlighted_results_for_component cell Refactor expiration time of cells cache Cache cells used view hooks defined for participatory processes Do not send upcoming meeting notification for hidden or withdrawn meetings (decidim#9134) Fix processes count in processes group title cell (decidim#9087) Fix attachments when called from Cells (decidim#9136) Clarify message to user when checking census (decidim#9112)
entantoencuanto
added a commit
that referenced
this pull request
Apr 7, 2022
* develop: Compile SCSS through sass-embedded (#9081) Prevent race condition between prevenTimeout and show modal (#9092) Bump elections dependencies to 0.23.0 (#9140) Reduce d3 bundle size (#9034) Improve wording when casting your vote (#9098) Do not send upcoming meeting notification for hidden or withdrawn meetings (#9134) Fix processes count in processes group title cell (#9087) Fix attachments when called from Cells (#9136) Clarify message to user when checking census (#9112)
andreslucena
pushed a commit
that referenced
this pull request
May 6, 2022
…tings (#9134) * Do not send upcoming meeting notification hidden or withdrawn meetings. * Refactoring
Merged
12 tasks
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
It can be noticed that the 48h notification is received for a hidden/withdrawn meeting.
📌 Related Issues
Link your PR to an issue
Testing
Steps to reproduce the behavior (hidden meeting):
Create a meeting that will start in 48h and a few minutes
Report the meeting
Hide the meeting via Admin dashboard - Reports
Wait for the notification
Notification is received
Steps to reproduce the behavior (withdrawn meeting):
Create a meeting that will start in 48h and a few minutes
Withdraw the meeting
Wait for the notification
Notification is received
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.📷 Screenshots
Please add screenshots of the changes you're proposing
