Skip to content

Clarify message to user when checking census#9112

Merged
ahukkanen merged 2 commits intodevelopfrom
fix/elections-invalid-census
Apr 6, 2022
Merged

Clarify message to user when checking census#9112
ahukkanen merged 2 commits intodevelopfrom
fix/elections-invalid-census

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

Change some strings while checking census on elections that appeared in the voting simulation.

Superseds #9096

♥️ Thank you!

@andreslucena andreslucena added module: elections type: fix PRs that implement a fix for a bug labels Mar 29, 2022
@andreslucena
Copy link
Copy Markdown
Member Author

It's also moving a file [_attachments.erb]. If this isn't done then when going to the votings index frontend page (/votings) you have an exception about a missing partial (I've seen the fix in other PRs with fixes from elections module).

@andreslucena andreslucena requested a review from ahukkanen April 4, 2022 11:01
@ahukkanen
Copy link
Copy Markdown
Contributor

It's also moving a file [_attachments.erb]. If this isn't done then when going to the votings index frontend page (/votings) you have an exception about a missing partial (I've seen the fix in other PRs with fixes from elections module).

@andreslucena Could we add a regression test that the /votings page can be loaded?

@andreslucena
Copy link
Copy Markdown
Member Author

@ahukkanen I've done that in #9136 as I found other missing files while working in the spec.

@ahukkanen ahukkanen merged commit 07fdb23 into develop Apr 6, 2022
@ahukkanen ahukkanen deleted the fix/elections-invalid-census branch April 6, 2022 08:20
entantoencuanto added a commit to PopulateTools/decidim that referenced this pull request Apr 6, 2022
…into pwa-staging

* chore/cache_highligted_resources_for_components_cells:
  Define expiry_time on highlighted_results_for_component cell
  Refactor expiration time of cells cache
  Cache cells used view hooks defined for participatory processes
  Do not send upcoming meeting notification for hidden or withdrawn meetings (decidim#9134)
  Fix processes count in processes group title cell (decidim#9087)
  Fix attachments when called from Cells (decidim#9136)
  Clarify message to user when checking census (decidim#9112)
entantoencuanto added a commit that referenced this pull request Apr 7, 2022
* develop:
  Compile SCSS through sass-embedded (#9081)
  Prevent race condition between prevenTimeout and show modal (#9092)
  Bump elections dependencies to 0.23.0 (#9140)
  Reduce d3 bundle size (#9034)
  Improve wording when casting your vote (#9098)
  Do not send upcoming meeting notification for hidden or withdrawn meetings (#9134)
  Fix processes count in processes group title cell (#9087)
  Fix attachments when called from Cells (#9136)
  Clarify message to user when checking census (#9112)
andreslucena added a commit that referenced this pull request May 6, 2022
* Clarify message to user when checking census

* Rename again the attachments partial file
andreslucena added a commit that referenced this pull request May 6, 2022
* Clarify message to user when checking census

* Rename again the attachments partial file
andreslucena added a commit that referenced this pull request May 6, 2022
* Clarify message to user when checking census

* Rename again the attachments partial file
ahukkanen pushed a commit that referenced this pull request May 10, 2022
* Clarify message to user when checking census

* Rename again the attachments partial file
@alecslupu alecslupu added this to the 0.27.0 milestone Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: elections type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants