Prevent race condition between prevenTimeout and show modal#9092
Merged
ahukkanen merged 1 commit intodecidim:developfrom Apr 7, 2022
Merged
Prevent race condition between prevenTimeout and show modal#9092ahukkanen merged 1 commit intodecidim:developfrom
ahukkanen merged 1 commit intodecidim:developfrom
Conversation
Contributor
Author
|
Can bet tested @ https://eero.populihub.app/processes/curriculum-ambiguous/f/12/meetings/73 there is 3min timeout delay. |
Member
|
Tried it locally and I see the behavior described: Logged in as admin, with a live ongoing meeting and another tab opened with /admin, I see the timeout modal in this tab after a couple of minutes (I have DECIDIM_EXPIRE_SESSION_AFTER=2). |
andreslucena
reviewed
Apr 4, 2022
andreslucena
approved these changes
Apr 5, 2022
ahukkanen
approved these changes
Apr 7, 2022
Contributor
|
Can you backport to 0.26 @lahdeero 🙏 |
Contributor
Author
|
@ahukkanen 0.26 already has this, I found this bug when testing previous backport. |
entantoencuanto
added a commit
that referenced
this pull request
Apr 7, 2022
* develop: Compile SCSS through sass-embedded (#9081) Prevent race condition between prevenTimeout and show modal (#9092) Bump elections dependencies to 0.23.0 (#9140) Reduce d3 bundle size (#9034) Improve wording when casting your vote (#9098) Do not send upcoming meeting notification for hidden or withdrawn meetings (#9134) Fix processes count in processes group title cell (#9087) Fix attachments when called from Cells (#9136) Clarify message to user when checking census (#9112)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
After #9070 there is race condition between preventing timeout and showing timeout modal. So if user has meeting going on in tab A and homepage open in tab B, tab B could still show logout modal even if tab A is preventing timeout.
📌 Related Issues
#9070
#9091
Testing
📋 Checklist
🚨 Please review the guidelines for contributing to this repository.
docs/.