Skip to content

Remove creation date from meeting card#7922

Merged
mrcasals merged 2 commits intodevelopfrom
7292-remove_creation_date_of_meeting_card
Apr 30, 2021
Merged

Remove creation date from meeting card#7922
mrcasals merged 2 commits intodevelopfrom
7292-remove_creation_date_of_meeting_card

Conversation

@entantoencuanto
Copy link
Copy Markdown
Contributor

@entantoencuanto entantoencuanto commented Apr 29, 2021

🎩 What? Why?

This PR removes default created_at item in statuses section of meetings m card to not show it. Also adds a test in cells

📌 Related Issues

Link your PR to an issue

Testing

Visit the meetings index of a participatory space The "Created at" shouldn't be present

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • ❓ CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • ❌AVOID breaking the continuous integration build.
  • ❌AVOID making significant changes to the overall architecture.

📷 Screenshots

Please add screenshots of the changes you're proposing

Screen Shot 2021-04-29 at 17 49 55

♥️ Thank you!

@entantoencuanto entantoencuanto marked this pull request as ready for review April 29, 2021 19:23
@mrcasals mrcasals changed the title 7292 remove creation date of meeting card Remove creation date from meeting card Apr 30, 2021
@mrcasals mrcasals merged commit cc6b0c5 into develop Apr 30, 2021
@mrcasals mrcasals deleted the 7292-remove_creation_date_of_meeting_card branch April 30, 2021 08:10
@mrcasals mrcasals added module: meetings type: change PRs that implement a change for an existing feature labels Apr 30, 2021
entantoencuanto added a commit that referenced this pull request Apr 30, 2021
@entantoencuanto
Merge branch 'develop' into active_storage_migration
c9d64f5 
* develop:
  Remove creation date from meeting card (#7922)
  Use NPM instead of yarn on CI (#7919)
  Validate nickname using correct regexp (#7900)
  Make webpacker build available in production (#7915)
  New Crowdin updates (#7911)
  Open attachments in new tab (#7912)
  Fix JS errors in the admin panel (#7903)
  Fix editor: remove br tags from inside a tags (#7901)
  Authorizable comment action for proposals (#6916)
  NoMethodError raised when voting comments from threads (#7880)
  Fix not signed in needs permission redirect for internal links (#7890)
  Fix meeting registrations questionnaire free text choice answers export (#7892)
  Store election verifiable results data in election (#7882)
  New Crowdin updates (#7884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@mrcasals mrcasals mrcasals approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

module: meetings type: change PRs that implement a change for an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove creation date of the meeting card

2 participants

@entantoencuanto @mrcasals