Skip to content

Store election verifiable results data in election#7882

Merged
mrcasals merged 2 commits intodevelopfrom
chore/store-verifiable-results-in-election
Apr 26, 2021
Merged

Store election verifiable results data in election#7882
mrcasals merged 2 commits intodevelopfrom
chore/store-verifiable-results-in-election

Conversation

@orlera
Copy link
Copy Markdown
Contributor

@orlera orlera commented Apr 22, 2021

🎩 What? Why?

Stores the data needed to verify the results of an election.

To this end, it:

  • Upgrades to the latest version of the BullettinBoard (0.21.0) that exposes the data we need to store;
  • Adds verifiable_results_file_url and verifiable_results_file_hash to the elections table;
  • Updates the UpdateElectionBulletinBoardStatus command to populate the above-mentioned fields with the data coming from the BullettinBoard;

📌 Related Issues

📋 Checklist

🚨 Please review the guidelines for contributing to this repository.

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

♥️ Thank you!

@orlera orlera self-assigned this Apr 22, 2021
@orlera orlera requested review from agustibr, beagleknight, leio10 and slickepinne and removed request for beagleknight April 22, 2021 16:24
Copy link
Copy Markdown
Contributor

@leio10 leio10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👏 🤩

@orlera orlera marked this pull request as ready for review April 23, 2021 14:52
@orlera
Copy link
Copy Markdown
Contributor Author

orlera commented Apr 23, 2021

Hi @decidim/mantainers! This can be reviewed 🔍

Copy link
Copy Markdown
Contributor

@beagleknight beagleknight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 🆗

@mrcasals mrcasals merged commit 727b68e into develop Apr 26, 2021
@mrcasals mrcasals deleted the chore/store-verifiable-results-in-election branch April 26, 2021 13:11
entantoencuanto added a commit that referenced this pull request Apr 30, 2021
* develop:
  Remove creation date from meeting card (#7922)
  Use NPM instead of yarn on CI (#7919)
  Validate nickname using correct regexp (#7900)
  Make webpacker build available in production (#7915)
  New Crowdin updates (#7911)
  Open attachments in new tab (#7912)
  Fix JS errors in the admin panel (#7903)
  Fix editor: remove br tags from inside a tags (#7901)
  Authorizable comment action for proposals (#6916)
  NoMethodError raised when voting comments from threads (#7880)
  Fix not signed in needs permission redirect for internal links (#7890)
  Fix meeting registrations questionnaire free text choice answers export (#7892)
  Store election verifiable results data in election (#7882)
  New Crowdin updates (#7884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: elections project: e-voting Barcelona City Council contract

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants