Skip to content

Fix JS errors in the admin panel#7903

Merged
mrcasals merged 2 commits intodecidim:developfrom
mainio:fix/admin-panel-js-errors
Apr 28, 2021
Merged

Fix JS errors in the admin panel#7903
mrcasals merged 2 commits intodecidim:developfrom
mainio:fix/admin-panel-js-errors

Conversation

@ahukkanen
Copy link
Copy Markdown
Contributor

@ahukkanen ahukkanen commented Apr 28, 2021

🎩 What? Why?

Right now there are some JS errors in the admin panel due to missing global Decidim objects.

This fixes those issues.

📌 Related Issues

Testing

  • Go to admin panel
  • See the JS console

📋 Checklist

  • CONSIDER adding a unit test if your PR resolves an issue.
  • ✔️ DO check open PR's to avoid duplicates.
  • ✔️ DO keep pull requests small so they can be easily reviewed.
  • ✔️ DO build locally before pushing.
  • ✔️ DO make sure tests pass.
  • ✔️ DO make sure any new changes are documented in docs/.
  • ✔️ DO add and modify seeds if necessary.
  • ✔️ DO add CHANGELOG upgrade notes if required.
  • ✔️ DO add to GraphQL API if there are new public fields.
  • ✔️ DO add link to MetaDecidim if it's a new feature.
  • AVOID breaking the continuous integration build.
  • AVOID making significant changes to the overall architecture.

📷 Screenshots

Admin panel JS errors

@ahukkanen ahukkanen changed the title Fix/admin panel js errors Fix JS errors in the admin panel Apr 28, 2021
@ferblape
Copy link
Copy Markdown
Contributor

Nice! I fixed them also in the Webpacker branch

@mrcasals mrcasals added module: admin type: fix PRs that implement a fix for a bug labels Apr 28, 2021
@mrcasals mrcasals merged commit 9b6cff7 into decidim:develop Apr 28, 2021
@ahukkanen ahukkanen deleted the fix/admin-panel-js-errors branch April 28, 2021 12:07
entantoencuanto added a commit that referenced this pull request Apr 30, 2021
* develop:
  Remove creation date from meeting card (#7922)
  Use NPM instead of yarn on CI (#7919)
  Validate nickname using correct regexp (#7900)
  Make webpacker build available in production (#7915)
  New Crowdin updates (#7911)
  Open attachments in new tab (#7912)
  Fix JS errors in the admin panel (#7903)
  Fix editor: remove br tags from inside a tags (#7901)
  Authorizable comment action for proposals (#6916)
  NoMethodError raised when voting comments from threads (#7880)
  Fix not signed in needs permission redirect for internal links (#7890)
  Fix meeting registrations questionnaire free text choice answers export (#7892)
  Store election verifiable results data in election (#7882)
  New Crowdin updates (#7884)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: admin type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants