Conversation
75c011d to
4f070a8
Compare
c6bf8c2 to
553f823
Compare
|
@decidim/product the last version of the PR is ready to be tested at staging, I don't know if its approved or if you want to try it |
|
@decidim/core this PR is rebased to #5883 to have GitHub Actions properly, I'll return to develop once that PR is merged. Also, circle task is failing because is not configured, and codeclimate is not working. |
553f823 to
0074e46
Compare
|
@decidim/product I'm waiting for your approval to this before asking for the technical review. Would you check it out at staging, please? 😬 |
|
LGTM (looks good to me) |
|
Thanks @josanFFiG! @decidim/core this is ready to be reviewed! :) |
|
@leio10 can you merge develop in order to solve changelog conflicts and run coverage please? |
0074e46 to
007a01c
Compare
tramuntanal
left a comment
There was a problem hiding this comment.
This is a very good job @leio10 ! 👍
I've left some comments, just some details 😄
decidim-proposals/app/cells/decidim/proposals/proposals_picker_cell.rb
Outdated
Show resolved
Hide resolved
decidim-proposals/app/presenters/decidim/proposals/proposal_presenter.rb
Outdated
Show resolved
Hide resolved
|
@tramuntanal done it! Sorry that I didn't answer before. ❤️ to your DataPicker test, if you prefer it, I could cherry-pick it to simplify the process. Regarding the coverage issues, the first problem is that coverage reports are failing a lot (problems when uploading to the server are ignored, failings when re-running jobs, wrong base commits used, etc), so it's being too hard to believe that information. I've created #5991 to improve its reliability, let's see if that helps us to get out of this problem. |
It is not needed anymore because the proposals picker has changed and now it doesn't allow selecting a "null proposal"
It is only for coherence purposes, even when nothing is broken.
|
@tramuntanal done! |
|
Woohoo! 🎉 |
* refactor: prepare DataPicker for supporting checkbox based selection * feat: add support for sorted checkboxes selection to DataPicker * fix: JS lint issues * feat: add proposals picker based on DataPicker * feat: use proposals picker on close meeting admin page * feat: use proposals picker on accountability result edit admin page * fix: missing line for precompiled assets * fix: scopes picker style broken during refactor * fix: scopes picker test broken during refactor * fix: don't allow selecting the same value twice in multiple mode * fix: undo decidim#4842, as it is not needed and it breaks admin scope selector It is not needed anymore because the proposals picker has changed and now it doesn't allow selecting a "null proposal" * fix: minor change on scopes picker tests It is only for coherence purposes, even when nothing is broken. * fix: i18n issues * feat: limits for proposals shown, using server-side filtering * docs: changelog entries added * style: lint issues and explicit parameters for presenter method * docs: update DataPicker's documentation and add examples of use * test: proposals picker test helpers updated & moved to proposals module * style: suggested changes applied * Test Decidim::FormBuilder#data_picker (decidim#5932) Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
🎩 What? Why?
This PR improves DataPicker in order to create a ProposalsPicker, that allows searching for proposals and selecting many of them at once. This ProposalsPicker is then used on two components of the admin zone:
This PR also undoes #4842, which is not necessary anymore, and that fix #5639.
📌 Related Issues
📋 Subtasks
CHANGELOGentry📷 Screenshots (optional)