Test Decidim::FormBuilder#data_picker#5932
Merged
leio10 merged 1 commit intofeat/improve_proposals_selectorfrom Apr 21, 2020
Merged
Test Decidim::FormBuilder#data_picker#5932leio10 merged 1 commit intofeat/improve_proposals_selectorfrom
leio10 merged 1 commit intofeat/improve_proposals_selectorfrom
Conversation
0eb9be8 to
e44a200
Compare
58eaac5 to
a259390
Compare
tramuntanal
added a commit
that referenced
this pull request
Apr 23, 2020
* refactor: prepare DataPicker for supporting checkbox based selection * feat: add support for sorted checkboxes selection to DataPicker * fix: JS lint issues * feat: add proposals picker based on DataPicker * feat: use proposals picker on close meeting admin page * feat: use proposals picker on accountability result edit admin page * fix: missing line for precompiled assets * fix: scopes picker style broken during refactor * fix: scopes picker test broken during refactor * fix: don't allow selecting the same value twice in multiple mode * fix: undo #4842, as it is not needed and it breaks admin scope selector It is not needed anymore because the proposals picker has changed and now it doesn't allow selecting a "null proposal" * fix: minor change on scopes picker tests It is only for coherence purposes, even when nothing is broken. * fix: i18n issues * feat: limits for proposals shown, using server-side filtering * docs: changelog entries added * style: lint issues and explicit parameters for presenter method * docs: update DataPicker's documentation and add examples of use * test: proposals picker test helpers updated & moved to proposals module * style: suggested changes applied * Test Decidim::FormBuilder#data_picker (#5932) Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
faithngetich
pushed a commit
to faithngetich/decidim
that referenced
this pull request
Apr 28, 2020
* refactor: prepare DataPicker for supporting checkbox based selection * feat: add support for sorted checkboxes selection to DataPicker * fix: JS lint issues * feat: add proposals picker based on DataPicker * feat: use proposals picker on close meeting admin page * feat: use proposals picker on accountability result edit admin page * fix: missing line for precompiled assets * fix: scopes picker style broken during refactor * fix: scopes picker test broken during refactor * fix: don't allow selecting the same value twice in multiple mode * fix: undo decidim#4842, as it is not needed and it breaks admin scope selector It is not needed anymore because the proposals picker has changed and now it doesn't allow selecting a "null proposal" * fix: minor change on scopes picker tests It is only for coherence purposes, even when nothing is broken. * fix: i18n issues * feat: limits for proposals shown, using server-side filtering * docs: changelog entries added * style: lint issues and explicit parameters for presenter method * docs: update DataPicker's documentation and add examples of use * test: proposals picker test helpers updated & moved to proposals module * style: suggested changes applied * Test Decidim::FormBuilder#data_picker (decidim#5932) Co-authored-by: Oliver Valls <oliver.vh@coditramuntana.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Add a basic test for
Decidim::FormBuilder#data_pickerso that it can be further extended.📌 Related Issues
📋 Subtasks
CHANGELOGentry