[FIX] Place `CurrentOrganization` middleware before `WardenManager`. by tramuntanal · Pull Request #4708 · decidim/decidim

tramuntanal · 2018-12-20T15:49:37Z

🎩 What? Why?

📌 Related Issues

Fixes Avoid failing redirects in omniauth strategies #4707

📋 Subtasks

Add CHANGELOG entry
[-] Add documentation regarding the feature
[-] Add/modify seeds
[-] Add tests
Fix

tramuntanal · 2018-12-20T17:09:18Z

May this PR be merged into v0.16?
I'm waiting to add the Changelog entry to avoid merge problems.

oriolgual · 2018-12-24T10:04:42Z

@tramuntanal I'm afraid you'll have to submit another one for 0.16-stable

…th_strategies

tramuntanal · 2018-12-28T10:43:31Z

@aitorlb would you backport this PR into 16-stable please?

tramuntanal · 2018-12-28T12:27:31Z

Ok @oriolgual , we'll do this for v0.17 and a backport to v0.16.
Can you notify us when master is stable please

…th_strategies

mrcasals · 2019-01-04T11:41:52Z

@tramuntanal master should be fixed on #4726

tramuntanal · 2019-01-07T13:13:40Z

Hi @mrcasals thanks but it seems that master is still broken

mrcasals · 2019-01-07T13:19:22Z

@tramuntanal can you rebase this PR (and the rest of them)? Those weird errors have already been solved at #4730 and #4731 😄

tramuntanal · 2019-01-07T13:25:14Z

@mrcasals yes, but I see here that master is not green. If I merge tests will fail again (probably for some other reason).

mrcasals · 2019-01-07T13:29:01Z

@tramuntanal The status checks this page shows for master are actually for l10n_master, for some reason unknown to me. Here are the latest builds for master:

https://circleci.com/gh/decidim/workflows/decidim/tree/master

…th_strategies

…' of ssh://github.com/decidim/decidim into fix/4707-Avoid_failing_redirects_in_omniauth_strategies

tramuntanal · 2019-01-07T13:52:46Z

@mrcasals master is now green! 👏

tramuntanal · 2019-01-07T16:24:54Z

@decidim/lot-core All checks have passed!

* Backport #4708 to 16-stable * Add CHANGELOG entry

* fix display of comments count when comment has been moderated * [BACKPORT] Use latest docker image for test env (decidim#4731) * Use latest docker image for test env * Bump Ruby version to match the one in tests * Fix conferences dependencies * Fix bundle version * Fix bundles * Backport decidim#4708 to 0.16-stable (decidim#4721) * Backport decidim#4708 to 16-stable * Add CHANGELOG entry * Add ability to toggle user groups by organization (decidim#4681) (decidim#4735) * Added a switch to organizations to disable user groups feature * Set user_groups_enabled attribute value in admin and system admin Default value is true, and can be modified by admins. * User groups methods moved to a new concern from UserProfile * Disable user groups when on core user pages * Disable user_groups on amendments * Disable user groups on admin * Disable user groups on proposals * Add changelog entry * [BACKPORT] MetricResolver filtering correction (decidim#4736) * [BACKPORT] MetricResolver filtering correction * Added CHANGELOG entry * Fix loading translations on comments (decidim#4728) (decidim#4739) This way they won't fail when there's a problem * New Crowdin translations (decidim#4738) * New translations en.yml (German) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (German) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Basque) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Italian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Dutch) * New translations en.yml (Dutch) * New translations en.yml (Dutch) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Galician) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Dutch) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (Dutch) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Turkish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Swedish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Russian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * Update bundles * 🐛 current_feature deprecated * Adds environment to open data export task to avoid errors (decidim#4743) * 🌐 FR --> Concertations #378 * 🌐 FR --> Concertations #378 * 🌐 FR --> Concertations #378 * Fix action authorizer with blank permissions 0.16 backport (decidim#4746) * Ignore blank permission options in action authorizer * Add CHANGELOG * 🐛 #417 : fix exports translatable_attr when first line is empty - add `empty_translatable` helper to provide blank values - fix `Decidim::Proposals::ProposalSerializer` - fix `Decidim::Comments::CommentSerializer` - fix `Decidim::Accountability::ResultSerializer` - TODO : need specific tests on headers * :robot: rubocop offense `C: Style/StringLiterals` * :bug: #360 fix survey choices export for free text option * ✨ #216 Survey answer date * ✨ #226 Survey answer date * 🤖 * 🐛 #421 fix Proposal mention links - only replace link when url contains "proposals" path - prevent switching between components with same item id * ✨ add mentions for Accountibility Results - add new `ContentProccessor` objects (`Parser` & `Renderer`) - add new `ResultPresenter` * ✨ add mentions for Budgets Projects - add new `ContentProccessor` objects (`Parser` & `Renderer`) - add new `ProjectPresenter` * ✅ fix tests for content parser * Backport decidim#4778 to 0.16-stable (decidim#4777) * Move code parent assemblies from index to partial * Refactor filtered assemblies query * Refactor filter assemblies helper and partial * Change tests * Add CHANGELOG entry * 🐛 fixes #344 for `NotifyProposalsMentionedJob` * 🐛 fixes #344 for `NotifyProposalsMentionedJob` * 🤖 rubocop #344 * ✅ fixes tests for #344 * 🤖 rubocop * Backport participatory text related evoutives and fixes. (decidim#4801) * Backport participatory text related evoutives and fixes. * Add changelog entry. * Update decidim_app-design Gemfile.lock. * Update decidim-generators Gemfile.lock. * Sort this PR's changelog entries for the next v0.16.1. * [TEST] Update participatory_text.odt document version with non ASCII symbols. * Backport decidim#4811 to 0.16-stable (decidim#4815) * Fix attachments not being inherited and add test * Add CHANGELOG entry * 🐛 fixes Pagination in assemblies #459 * 🐛 ✉️ add opt out notifications mail link - #RGPD * 🐛 unused keys * 🐛 💚 test_main * 🐛 💚 test_main * 🌐 💚 after patch

[FIX] Place CurrentOrganization middleware before WardenManager.

99c1112

tramuntanal self-assigned this Dec 20, 2018

ghost added the status: WIP label Dec 20, 2018

oriolgual previously approved these changes Dec 20, 2018

View reviewed changes

tramuntanal added 2 commits December 28, 2018 11:39

Merge branch 'master' into fix/4707-Avoid_failing_redirects_in_omniau…

7cae37f

…th_strategies

[DOC] Added Changelog entry.

e136481

tramuntanal dismissed oriolgual’s stale review via e136481 December 28, 2018 10:42

tramuntanal added in-review and removed status: WIP labels Dec 28, 2018

aitorlb added a commit that referenced this pull request Dec 28, 2018

Backport #4708 to 16-stable

819da13

ghost assigned aitorlb Dec 28, 2018

ghost added the status: WIP label Dec 28, 2018

aitorlb mentioned this pull request Dec 28, 2018

Backport #4708 to 0.16-stable #4721

Merged

1 task

Merge branch 'master' into fix/4707-Avoid_failing_redirects_in_omniau…

7a2ee0e

…th_strategies

ghost assigned mrcasals Jan 4, 2019

aitorlb removed the status: WIP label Jan 7, 2019

tramuntanal added 2 commits January 7, 2019 14:50

Merge branch 'master' into fix/4707-Avoid_failing_redirects_in_omniau…

095adcf

…th_strategies

Merge branch 'fix/4707-Avoid_failing_redirects_in_omniauth_strategies…

a813801

…' of ssh://github.com/decidim/decidim into fix/4707-Avoid_failing_redirects_in_omniauth_strategies

ghost added the status: WIP label Jan 7, 2019

tramuntanal removed the status: WIP label Jan 7, 2019

mrcasals approved these changes Jan 8, 2019

View reviewed changes

mrcasals merged commit 8351f60 into master Jan 8, 2019

mrcasals deleted the fix/4707-Avoid_failing_redirects_in_omniauth_strategies branch January 8, 2019 08:02

mrcasals pushed a commit that referenced this pull request Jan 8, 2019

Backport #4708 to 0.16-stable (#4721)

cfb7cad

* Backport #4708 to 16-stable * Add CHANGELOG entry

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[FIX] Place `CurrentOrganization` middleware before `WardenManager`.#4708

[FIX] Place `CurrentOrganization` middleware before `WardenManager`.#4708
mrcasals merged 6 commits intomasterfrom
fix/4707-Avoid_failing_redirects_in_omniauth_strategies

tramuntanal commented Dec 20, 2018 •

edited

Loading

Uh oh!

tramuntanal commented Dec 20, 2018

Uh oh!

oriolgual commented Dec 24, 2018

Uh oh!

tramuntanal commented Dec 28, 2018

Uh oh!

tramuntanal commented Dec 28, 2018

Uh oh!

mrcasals commented Jan 4, 2019

Uh oh!

tramuntanal commented Jan 7, 2019

Uh oh!

mrcasals commented Jan 7, 2019

Uh oh!

tramuntanal commented Jan 7, 2019 •

edited

Loading

Uh oh!

mrcasals commented Jan 7, 2019

Uh oh!

tramuntanal commented Jan 7, 2019

Uh oh!

tramuntanal commented Jan 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

tramuntanal commented Dec 20, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

📋 Subtasks

Uh oh!

tramuntanal commented Dec 20, 2018

Uh oh!

oriolgual commented Dec 24, 2018

Uh oh!

tramuntanal commented Dec 28, 2018

Uh oh!

tramuntanal commented Dec 28, 2018

Uh oh!

mrcasals commented Jan 4, 2019

Uh oh!

tramuntanal commented Jan 7, 2019

Uh oh!

mrcasals commented Jan 7, 2019

Uh oh!

tramuntanal commented Jan 7, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mrcasals commented Jan 7, 2019

Uh oh!

tramuntanal commented Jan 7, 2019

Uh oh!

tramuntanal commented Jan 7, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tramuntanal commented Dec 20, 2018 •

edited

Loading

tramuntanal commented Jan 7, 2019 •

edited

Loading