Add ability to toggle user groups by organization by leio10 · Pull Request #4681 · decidim/decidim

leio10 · 2018-12-19T11:34:29Z

🎩 What? Why?

This allows each organization to toggle the whole user groups feature on or off depending on their specific needs.

📌 Related Issues

Very very inspired in Add ability to toggle badges by organization #4249 😸

📋 Subtasks

Add CHANGELOG entry
Add documentation regarding the feature
Add/modify seeds
Add tests

📷 Screenshots (optional)

Default value is true, and can be modified by admins.

leio10 · 2018-12-19T16:04:36Z

@decidim/product are you ok with this feature?
If so, @decidim/developers this is ready to be reviewed 😁

carolromero · 2018-12-20T11:50:34Z

Hi @leio10, thanks for the PR! from @decidim/product side it's ok!

mrcasals · 2019-01-07T14:22:10Z

I've fixed the conflicts in the CHANGELOG

mrcasals · 2019-01-08T08:10:16Z

Looks good to me, merging! 😄

leio10 · 2019-01-08T08:49:28Z

❤️ thanks @mrcasals!!
It's a pity that it didn't make it for the 0.16 release.

mrcasals · 2019-01-08T08:51:26Z

@leio10 since the 0.16 version hasn't been released yet, I think we can backport it 😄 I'll send the PR!

* Added a switch to organizations to disable user groups feature * Set user_groups_enabled attribute value in admin and system admin Default value is true, and can be modified by admins. * User groups methods moved to a new concern from UserProfile * Disable user groups when on core user pages * Disable user_groups on amendments * Disable user groups on admin * Disable user groups on proposals * Add changelog entry

leio10 · 2019-01-08T08:54:30Z

@mrcasals you're my hero!! 😍😍

mrcasals · 2019-01-08T08:54:32Z

@leio10 see #4735!

* Added a switch to organizations to disable user groups feature * Set user_groups_enabled attribute value in admin and system admin Default value is true, and can be modified by admins. * User groups methods moved to a new concern from UserProfile * Disable user groups when on core user pages * Disable user_groups on amendments * Disable user groups on admin * Disable user groups on proposals * Add changelog entry

* fix display of comments count when comment has been moderated * [BACKPORT] Use latest docker image for test env (decidim#4731) * Use latest docker image for test env * Bump Ruby version to match the one in tests * Fix conferences dependencies * Fix bundle version * Fix bundles * Backport decidim#4708 to 0.16-stable (decidim#4721) * Backport decidim#4708 to 16-stable * Add CHANGELOG entry * Add ability to toggle user groups by organization (decidim#4681) (decidim#4735) * Added a switch to organizations to disable user groups feature * Set user_groups_enabled attribute value in admin and system admin Default value is true, and can be modified by admins. * User groups methods moved to a new concern from UserProfile * Disable user groups when on core user pages * Disable user_groups on amendments * Disable user groups on admin * Disable user groups on proposals * Add changelog entry * [BACKPORT] MetricResolver filtering correction (decidim#4736) * [BACKPORT] MetricResolver filtering correction * Added CHANGELOG entry * Fix loading translations on comments (decidim#4728) (decidim#4739) This way they won't fail when there's a problem * New Crowdin translations (decidim#4738) * New translations en.yml (German) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Hungarian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (German) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (German) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Basque) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Italian) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Polish) * New translations en.yml (Italian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Indonesian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Italian) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Dutch) * New translations en.yml (Dutch) * New translations en.yml (Dutch) * New translations en.yml (Dutch) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Galician) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Basque) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Catalan) * New translations en.yml (Dutch) * New translations en.yml (Dutch) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (French) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (Dutch) * New translations en.yml (Galician) * New translations en.yml (Galician) * New translations en.yml (French) * New translations en.yml (Finnish) * New translations en.yml (Dutch) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Finnish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Turkish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Swedish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Turkish) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Ukrainian with many plural form) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Finnish (plain)) * New translations en.yml (Russian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Russian with many plural form) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Swedish) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese, Brazilian) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Polish) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Portuguese) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Swedish) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Swedish) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish) * New translations en.yml (Spanish, Paraguay) * New translations en.yml (Spanish, Paraguay) * Update bundles * 🐛 current_feature deprecated * Adds environment to open data export task to avoid errors (decidim#4743) * 🌐 FR --> Concertations #378 * 🌐 FR --> Concertations #378 * 🌐 FR --> Concertations #378 * Fix action authorizer with blank permissions 0.16 backport (decidim#4746) * Ignore blank permission options in action authorizer * Add CHANGELOG * 🐛 #417 : fix exports translatable_attr when first line is empty - add `empty_translatable` helper to provide blank values - fix `Decidim::Proposals::ProposalSerializer` - fix `Decidim::Comments::CommentSerializer` - fix `Decidim::Accountability::ResultSerializer` - TODO : need specific tests on headers * :robot: rubocop offense `C: Style/StringLiterals` * :bug: #360 fix survey choices export for free text option * ✨ #216 Survey answer date * ✨ #226 Survey answer date * 🤖 * 🐛 #421 fix Proposal mention links - only replace link when url contains "proposals" path - prevent switching between components with same item id * ✨ add mentions for Accountibility Results - add new `ContentProccessor` objects (`Parser` & `Renderer`) - add new `ResultPresenter` * ✨ add mentions for Budgets Projects - add new `ContentProccessor` objects (`Parser` & `Renderer`) - add new `ProjectPresenter` * ✅ fix tests for content parser * Backport decidim#4778 to 0.16-stable (decidim#4777) * Move code parent assemblies from index to partial * Refactor filtered assemblies query * Refactor filter assemblies helper and partial * Change tests * Add CHANGELOG entry * 🐛 fixes #344 for `NotifyProposalsMentionedJob` * 🐛 fixes #344 for `NotifyProposalsMentionedJob` * 🤖 rubocop #344 * ✅ fixes tests for #344 * 🤖 rubocop * Backport participatory text related evoutives and fixes. (decidim#4801) * Backport participatory text related evoutives and fixes. * Add changelog entry. * Update decidim_app-design Gemfile.lock. * Update decidim-generators Gemfile.lock. * Sort this PR's changelog entries for the next v0.16.1. * [TEST] Update participatory_text.odt document version with non ASCII symbols. * Backport decidim#4811 to 0.16-stable (decidim#4815) * Fix attachments not being inherited and add test * Add CHANGELOG entry * 🐛 fixes Pagination in assemblies #459 * 🐛 ✉️ add opt out notifications mail link - #RGPD * 🐛 unused keys * 🐛 💚 test_main * 🐛 💚 test_main * 🌐 💚 after patch

paarals · 2019-02-20T12:00:43Z

Hello @leio10 and @mrcasals, I have a very basic doubt. How is it possible that in the changelog of 0.16 and master, is the same PR referenced?

agustibr · 2019-02-22T12:44:10Z

@paarals because its backported, so should the 0.16 Changelog reference the #4735 and not this PR?

leio10 added 5 commits December 19, 2018 12:30

Added a switch to organizations to disable user groups feature

30a92cd

Set user_groups_enabled attribute value in admin and system admin

e52dfe7

Default value is true, and can be modified by admins.

User groups methods moved to a new concern from UserProfile

d4fc9e4

Disable user groups when on core user pages

357d6a6

Disable user_groups on amendments

3975868

ghost assigned leio10 Dec 19, 2018

ghost added the status: WIP label Dec 19, 2018

leio10 added 3 commits December 19, 2018 13:00

Disable user groups on admin

413e756

Disable user groups on proposals

21db886

Add changelog entry

1149bba

leio10 force-pushed the features/disable_user_groups branch from 7383b21 to 1149bba Compare December 19, 2018 12:00

leio10 removed the status: WIP label Dec 19, 2018

mrcasals added the in-review label Dec 20, 2018

Merge branch 'master' into features/disable_user_groups

8926aec

ghost assigned mrcasals Jan 7, 2019

ghost added the status: WIP label Jan 7, 2019

mrcasals removed the status: WIP label Jan 7, 2019

mrcasals self-requested a review January 7, 2019 14:22

mrcasals approved these changes Jan 8, 2019

View reviewed changes

mrcasals merged commit 36cc08c into decidim:master Jan 8, 2019

leio10 deleted the features/disable_user_groups branch January 8, 2019 08:46

mrcasals mentioned this pull request Jan 8, 2019

[Backport] Add ability to toggle user groups by organization #4735

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add ability to toggle user groups by organization#4681

Add ability to toggle user groups by organization#4681
mrcasals merged 9 commits intodecidim:masterfrom
podemos-info:features/disable_user_groups

leio10 commented Dec 19, 2018 •

edited

Loading

Uh oh!

leio10 commented Dec 19, 2018

Uh oh!

carolromero commented Dec 20, 2018

Uh oh!

mrcasals commented Jan 7, 2019

Uh oh!

mrcasals commented Jan 8, 2019

Uh oh!

leio10 commented Jan 8, 2019

Uh oh!

mrcasals commented Jan 8, 2019

Uh oh!

leio10 commented Jan 8, 2019

Uh oh!

mrcasals commented Jan 8, 2019

Uh oh!

paarals commented Feb 20, 2019

Uh oh!

agustibr commented Feb 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

leio10 commented Dec 19, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📌 Related Issues

📋 Subtasks

📷 Screenshots (optional)

Uh oh!

leio10 commented Dec 19, 2018

Uh oh!

carolromero commented Dec 20, 2018

Uh oh!

mrcasals commented Jan 7, 2019

Uh oh!

mrcasals commented Jan 8, 2019

Uh oh!

leio10 commented Jan 8, 2019

Uh oh!

mrcasals commented Jan 8, 2019

Uh oh!

leio10 commented Jan 8, 2019

Uh oh!

mrcasals commented Jan 8, 2019

Uh oh!

paarals commented Feb 20, 2019

Uh oh!

agustibr commented Feb 22, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

leio10 commented Dec 19, 2018 •

edited

Loading