Closed
Conversation
2 tasks
oriolgual
previously approved these changes
Jan 4, 2019
f53914d to
38c65be
Compare
Contributor
|
Not sure about this, although I understand the tradeoff. Is there any underlying unit tests? |
Contributor
Author
|
@josepjaume there are no tests about the file generation, but this is blocking us from releasing any new version, and it's messing with everyone's development because Maybe @MarcReniu or someone else from @decidim/lot-mods can look fir a better way to test this? |
Contributor
Author
|
Ah, wait, it seems to be an error caused by an outdated version of chromedriver: I'll try to fix it! |
Contributor
Author
|
OK, updating chromedriver locally fixes the errors, I'm closing this PR! |
Contributor
|
Nice! Thanks for finding the source of the issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
These tests are consistently failing and we can't find a way to fix them. Also, they're testing a feature that holds no real value to a user, IMO: the downloaded file only contains the data displayed in the page (instead of all the historical data), and has no context ("what process does it belong to?").
We're removing these tests so development can keep going, and we'll readd them once we can make them work.
📌 Related Issues
None
📋 Subtasks
None