Conversation
alecslupu
suggested changes
Jan 29, 2024
Contributor
alecslupu
left a comment
There was a problem hiding this comment.
Just a small change, and we are good to go.
Co-authored-by: Alexandru Emil Lupu <contact@alecslupu.ro>
entantoencuanto
added a commit
that referenced
this pull request
Feb 1, 2024
* develop: Remove elections module (#12366) Fix flaky for questionnaire drag and drop question (#12367) Redesign: datepicker (#11768) Patch participatory spaces factories (#12341) Upgrade chromedriver to v120+ (#12351) Fix bug in welcome notifications when the organization has weird characters (#12326) Have only one h1 in the admin pages (#12340) Fix voting data migration for AddFollowableCounterCacheToVotings (#12350) New Crowdin updates (#12282) Fix broken links in debates index (#12343)
entantoencuanto
added a commit
that referenced
this pull request
Feb 2, 2024
…design-staging * fix/desgin-application-cell-components: (141 commits) Fix linters Add spellcheck="false" to remaining textareas with code Remove follow component page unused static elements Remove report component page unused static elements Fix process groups s cell card Fix style of design_table displaying cards Change cards component page to use cells and examples of code Replace static html with cell calls and use examples of code in author component page Replace static html with cell calls and use examples of code in address component page Rename sections Remove elections module (#12366) Fix flaky for questionnaire drag and drop question (#12367) Extend examples of cells in annonuncements and tab panels pages Ignore empty call_string items and remove spaces Add spellcheck="false" to code textareas Allow using multiple entries in call_string and update buttons component page Redesign: datepicker (#11768) Patch participatory spaces factories (#12341) Upgrade chromedriver to v120+ (#12351) Fix bug in welcome notifications when the organization has weird characters (#12326) ...
Contributor
|
This cnnot be backported to 0.27 as there are some dependencies removed ( mustache ) |
Member
Author
If you want we can leave that dependency there even though its no longer used (I prefer that vs the alternative of not fixing this bug in that version) |
Member
Author
|
Removing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
While working in #12323, I had a flaky spec:
This PR fixes it, and also removes a dependency that was only used here (
mustachegem)📌 Related Issues
Testing
CI should be green. You can copy the spec and see that it currently fails in develop without the fix.
📷 Screenshots