Skip to content

Fix broken links in debates index#12343

Merged
alecslupu merged 1 commit intodevelopfrom
fix/debates-index-link
Jan 29, 2024
Merged

Fix broken links in debates index#12343
alecslupu merged 1 commit intodevelopfrom
fix/debates-index-link

Conversation

@andreslucena
Copy link
Copy Markdown
Member

🎩 What? Why?

It was detected that if a debates description has a link in the first line, the design gets broken. This PR fixes that.

📌 Related Issues

Testing

  1. Go to a debates component
  2. Create a new debate with a link in the first line of the description
  3. See the design broken (without the patch)
  4. Apply the patch
  5. See the design well

📷 Screenshots

Debate with link:

Screenshot of the debate with link

Without this patch

Screenshot of the bug

With this patch

Screenshot of the fix

♥️ Thank you!

@andreslucena andreslucena added module: debates type: fix PRs that implement a fix for a bug labels Jan 26, 2024
@andreslucena andreslucena marked this pull request as ready for review January 26, 2024 14:55
Copy link
Copy Markdown
Contributor

@alecslupu alecslupu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alecslupu alecslupu merged commit 7b038de into develop Jan 29, 2024
@alecslupu alecslupu deleted the fix/debates-index-link branch January 29, 2024 12:07
entantoencuanto added a commit that referenced this pull request Feb 1, 2024
* develop:
  Remove elections module (#12366)
  Fix flaky for questionnaire drag and drop question (#12367)
  Redesign: datepicker (#11768)
  Patch participatory spaces factories (#12341)
  Upgrade chromedriver to v120+ (#12351)
  Fix bug in welcome notifications when the organization has weird characters (#12326)
  Have only one h1 in the admin pages (#12340)
  Fix voting data migration for AddFollowableCounterCacheToVotings (#12350)
  New Crowdin updates (#12282)
  Fix broken links in debates index (#12343)
@alecslupu alecslupu added the no-backport Pull Requests that should not be backported label Feb 14, 2024
@alecslupu
Copy link
Copy Markdown
Contributor

I have added the no-backport label as we already stripping tags in 0.27. Also, the patch applies to a file that does not exists in 0.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

module: debates no-backport Pull Requests that should not be backported type: fix PRs that implement a fix for a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Debates list design broken when the description has a link

2 participants