Have only one h1 in the admin pages#12340
Conversation
There was a problem hiding this comment.
We also need to fix the following H1s, that i have ignored, afetr I have checked that there is no error highlighted by WGAC:
Also, while back tracking the PR, i have found 3 indent issues.
- decidim-templates/app/views/decidim/templates/admin/questionnaire_templates/edit.html.erb
- decidim-meetings/app/views/decidim/meetings/admin/registrations/edit.html.erb
- decidim-meetings/app/views/decidim/meetings/admin/invites/index.html.erb
- decidim-initiatives/app/views/decidim/initiatives/admin/answers/edit.html.erb
- decidim-elections/app/views/decidim/votings/admin/monitoring_committee_verify_elections/index.html.erb
- decidim-admin/app/views/decidim/admin/newsletter_templates/index.html.erb
- decidim-admin/app/views/decidim/admin/help_sections/_form.html.erb
Indent issue:
- decidim-elections/app/views/decidim/votings/admin/votings/edit.html.erb ( lines 4-6)
- decidim-elections/app/views/decidim/votings/admin/polling_officers/new.html.erb ( 3-5)
- decidim-elections/app/views/decidim/elections/admin/elections/edit.html.erb ( 3-5 )
Detected on code review
Detected in code review
I've fixed both of these issues, so this is ready for another round |
alecslupu
left a comment
There was a problem hiding this comment.
This looks good from code point of view. There one small change that still needs to be done in decidim-initiatives/app/views/decidim/initiatives/admin/answers/edit.html.erb
Detected on code review
Done in 519aac3 |
alecslupu
left a comment
There was a problem hiding this comment.
Approving without running on local.
* develop: Remove elections module (#12366) Fix flaky for questionnaire drag and drop question (#12367) Redesign: datepicker (#11768) Patch participatory spaces factories (#12341) Upgrade chromedriver to v120+ (#12351) Fix bug in welcome notifications when the organization has weird characters (#12326) Have only one h1 in the admin pages (#12340) Fix voting data migration for AddFollowableCounterCacheToVotings (#12350) New Crowdin updates (#12282) Fix broken links in debates index (#12343)
🎩 What? Why?
As I mentioned in a comment:
#12324 (comment)
We should only have on h1 in each page, so this PR fixes that.