Fix webpack generation on cells specs#12323
Merged
Conversation
Allows running a cell spec as the first spec on a newly generated `test_app`. Without this you'd get a Shackapacker error: > Shakapacker::Manifest::MissingEntryError
This was referenced Jan 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Allows running a cell spec as the first spec on a newly generated
test_app. Without this you'd get a Shackapacker error:For the past hour we've been debugging with @greenwoodt this error 🙃
I think this may be related to some flaky specs that we've seen, so I'd want to backport this to v0.28 at least.
Testing
Without this patch:
See exceptions related to Shakapacker
With this patch:
See that it works well