Skip to content

New admin - Settings section#1124

Merged
beagleknight merged 9 commits intorevamp_adminfrom
new-admin/settings
Mar 15, 2017
Merged

New admin - Settings section#1124
beagleknight merged 9 commits intorevamp_adminfrom
new-admin/settings

Conversation

@beagleknight
Copy link
Copy Markdown
Contributor

@beagleknight beagleknight commented Mar 15, 2017

🎩 What? Why?

I removed #1115 doing a bad rebase.

Add settings and scopes admin sections to the new admin.

📌 Related Issues

📋 Subtasks

None

📷 Screenshots (optional)

None

👻 GIF

None

@mention-bot
Copy link
Copy Markdown

@beagleknight, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mrcasals and @josepjaume to be potential reviewers.

@mrcasals
Copy link
Copy Markdown
Contributor

Tests fail :/

@beagleknight
Copy link
Copy Markdown
Contributor Author

Yeah, on it! :)

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 15, 2017

Codecov Report

Merging #1124 into revamp_admin will decrease coverage by 0.01%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##           revamp_admin    #1124      +/-   ##
================================================
- Coverage         97.18%   97.17%   -0.02%     
================================================
  Files               420      421       +1     
  Lines              6998     7037      +39     
================================================
+ Hits               6801     6838      +37     
- Misses              197      199       +2
Impacted Files Coverage Δ
...app/controllers/decidim/admin/scopes_controller.rb 91.11% <100%> (+0.2%)
...in/app/helpers/decidim/admin/application_helper.rb 100% <100%> (ø)
decidim-core/lib/decidim/form_builder.rb 97.81% <100%> (+0.03%)
decidim-core/app/models/decidim/organization.rb 94.44% <100%> (+0.32%)
...ntrollers/decidim/admin/organization_controller.rb 91.3% <100%> (+0.39%)
...ontrollers/decidim/admin/moderations_controller.rb 88.23% <0%> (ø)
...proposals/app/models/decidim/proposals/proposal.rb 100% <0%> (+2.56%)
...im-comments/app/models/decidim/comments/comment.rb 100% <0%> (+3.12%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e470ecd...79d81a4. Read the comment docs.

@beagleknight beagleknight self-assigned this Mar 15, 2017
@beagleknight beagleknight merged commit 98ca9e0 into revamp_admin Mar 15, 2017
@beagleknight beagleknight deleted the new-admin/settings branch March 15, 2017 14:13
beagleknight added a commit that referenced this pull request Mar 21, 2017
* Add participatory process layout

* Add basic layout for settings

* Finish settings form

* Add scopes index page

* Finish basic scopes admin

* Add revamp_admin to travis

* Fix a few specs

* Fix broken tests

* Remove bad merge
beagleknight added a commit that referenced this pull request Mar 27, 2017
* Add participatory process layout

* Add basic layout for settings

* Finish settings form

* Add scopes index page

* Finish basic scopes admin

* Add revamp_admin to travis

* Fix a few specs

* Fix broken tests

* Remove bad merge
beagleknight added a commit that referenced this pull request Mar 28, 2017
* Add participatory process layout

* Add basic layout for settings

* Finish settings form

* Add scopes index page

* Finish basic scopes admin

* Add revamp_admin to travis

* Fix a few specs

* Fix broken tests

* Remove bad merge
beagleknight added a commit that referenced this pull request Mar 29, 2017
* Add participatory process layout

* Add basic layout for settings

* Finish settings form

* Add scopes index page

* Finish basic scopes admin

* Add revamp_admin to travis

* Fix a few specs

* Fix broken tests

* Remove bad merge
beagleknight pushed a commit that referenced this pull request Mar 30, 2017
* Add admin styles

* Add basic layout

* Change scopes icon

* Add participatory processes index page

* Add participatory process layout

* Fix some specs

* Fix more broken tests

* Fix more specs

* Fix poltergeist

* New admin - Settings section (#1124)

* Add participatory process layout

* Add basic layout for settings

* Finish settings form

* Add scopes index page

* Finish basic scopes admin

* Add revamp_admin to travis

* Fix a few specs

* Fix broken tests

* Remove bad merge

* [New admin] - Pages section (#1130)

* Add index section

* Add new section

* Finish forms

* Fix specs

* [New admin] - Users (#1136)

* Add layout

* Add users index page

* Add invite user form

* Add user groups index and fix pagination for both users and user groups

* Fix table links

* Fix specs

* Fix admin invite user labels

* [New admin] - Newsletters (#1140)

* Add layout and index page

* Add new/edit forms

* Add newsletter preview

* Fix specs

* [New Admin] - Process groups (#1141)

* Add new views

* Fix broken specs

* [New Admin] - Style process features (#1143)

* Style process features

* Refactor feature tests for admin

* [New Admin] - Processes info / steps (#1138)

* updated new process view

* updated process steps index

* update process steps index table

* update processes layouts

* Processes steps views updated

* Fix indentation

* Remove unusued locales

* Update tests

* Add moderations missing menu

* missing td added

* Add icon link helper (#1155)

* Add icon link helper

* Update existing icon links

* Add optional data to icon link helper

* Add methods at icon links

* Refactor tests for new icon helper

* Add docs and refactor helper call

* Refactor all icon links with new helper call

* [New Admin] Update category views. (#1148)

* Add category views

* Fix tests

* Add tests

* Add new icon_helper

* [New Admin] Attachment update. (#1158)

* Views added

* Finish tests

* add helper

* Style process features at admin (#1149)

* [New Admin] - Process groups (#1141)

* Add new views

* Fix broken specs

* Style meetings table

* Update branch with icon helper

* Style proposals

* Style results

* Style budgets

* Update missing styles for some forms

* Fix most of the tests

* Fix more tests

* Style moderation tables (#1182)

* Remove unused travis step

* [New Admin] Update process admins views. (#1183)

* Add new and edit forms

* clean update command

* Tests added

* Amend test

* Add dashboard content

* Spellcheck

* Amend managing roles strings

* Use user instead of admin

* Fix participatory process edit button

* Add some feedback

* Add styles for feature forms

* Add edit feature form

* Add more feedback

* [New Admin] Html and styles review. (#1200)

* Review all the forms

* Class coherence review

* CA: Swap funcionalitat with component

* Fix a few specs

* ES: Swap funcionalidad with componente

* Fix a few more specs

* Add missing helper

* Add preview images to organization settings form

* Icons updated on features table

* amend icon
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants