New admin - Settings section#1115
Merged
beagleknight merged 6 commits intorevamp_adminfrom Mar 15, 2017
Merged
Conversation
8c64ed4 to
ab7738f
Compare
|
@beagleknight, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mrcasals and @josepjaume to be potential reviewers. |
7fe8a67 to
bd8bfbc
Compare
ab7738f to
ddc5a5c
Compare
josepjaume
approved these changes
Mar 15, 2017
| </div> | ||
|
|
||
| <div class="columns xlarge-6"> | ||
| <div class="label--tabs"> |
Contributor
There was a problem hiding this comment.
Nice! Are they just foundation tabs?
Contributor
Author
There was a problem hiding this comment.
Yeah, they are foundation tabs :)
Codecov Report
@@ Coverage Diff @@
## revamp_admin #1115 +/- ##
================================================
+ Coverage 96.99% 97.12% +0.12%
================================================
Files 413 412 -1
Lines 6916 6876 -40
================================================
- Hits 6708 6678 -30
+ Misses 208 198 -10
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## revamp_admin #1115 +/- ##
================================================
+ Coverage 96.99% 97.18% +0.19%
================================================
Files 413 413
Lines 6916 6921 +5
================================================
+ Hits 6708 6726 +18
+ Misses 208 195 -13
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Add settings and scopes admin sections to the new admin.
📌 Related Issues
📋 Subtasks
📷 Screenshots (optional)
👻 GIF
None