Admin panel refactor by josepjaume · Pull Request #1101 · decidim/decidim

josepjaume · 2017-03-10T15:16:15Z

🎩 What? Why?

Add new admin styles. This is a work in progress and implies work in each and every feature. This PR is the entry point for multiple other PRs that we'll work on in parallel.

📝 Documentation

Repo: https://github.com/AjuntamentdeBarcelona/decidim-design-admin
Demo: http://decidim-design-admin.herokuapp.com/
Icons: http://useiconic.com/open

📌 Related Issues

📋 Subtasks

📷 Screenshots (optional)

👻 GIF

codecov-io · 2017-03-14T11:09:22Z

Codecov Report

Merging #1101 into master will decrease coverage by 0.37%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1101      +/-   ##
==========================================
- Coverage   97.17%   96.79%   -0.38%     
==========================================
  Files         413      411       -2     
  Lines        6903     6869      -34     
==========================================
- Hits         6708     6649      -59     
- Misses        195      220      +25

Impacted Files	Coverage Δ
decidim-core/lib/decidim/core.rb	`100% <100%> (ø)`	✅
decidim-comments/lib/decidim/comments/engine.rb	`100% <100%> (ø)`	✅
decidim-core/lib/decidim/core/engine.rb	`98.48% <100%> (+0.02%)`	✅
decidim-system/lib/decidim/system/engine.rb	`100% <100%> (ø)`	✅
decidim-admin/lib/decidim/admin/engine.rb	`100% <100%> (ø)`	✅
...in/app/helpers/decidim/admin/application_helper.rb	`100% <100%> (ø)`	✅
.../app/controllers/decidim/application_controller.rb	`96.15% <100%> (ø)`	✅
...ecidim/admin/participatory_processes_controller.rb	`43.13% <0%> (-49.02%)`	❌
.../decidim/admin/process_groups_for_select_helper.rb	`66.66% <0%> (-33.34%)`	❌
.../forms/decidim/admin/participatory_process_form.rb	`94.59% <0%> (-5.41%)`	❌
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd4d530...bd4ac51. Read the comment docs.

codecov-io · 2017-03-14T11:09:23Z

Codecov Report

Merging #1101 into master will decrease coverage by 0.14%.
The diff coverage is 93.42%.

@@            Coverage Diff             @@
##           master    #1101      +/-   ##
==========================================
- Coverage   97.16%   97.01%   -0.15%     
==========================================
  Files         422      424       +2     
  Lines        7053     7109      +56     
==========================================
+ Hits         6853     6897      +44     
- Misses        200      212      +12

Impacted Files	Coverage Δ
...dmin/app/helpers/decidim/admin/icon_link_helper.rb	`100% <100%> (ø)`
...ontrollers/decidim/admin/user_groups_controller.rb	`100% <100%> (ø)`	⬆️
...app/controllers/decidim/admin/scopes_controller.rb	`91.11% <100%> (+0.2%)`	⬆️
decidim-admin/config/routes.rb	`100% <100%> (ø)`	⬆️
...ecidim/admin/participatory_processes_controller.rb	`92.15% <100%> (ø)`	⬆️
.../app/controllers/decidim/admin/users_controller.rb	`90.47% <100%> (ø)`	⬆️
decidim-core/app/models/decidim/organization.rb	`94.44% <100%> (+0.32%)`	⬆️
...ecidim/admin/update_participatory_process_admin.rb	`100% <100%> (ø)`
...ontrollers/decidim/admin/application_controller.rb	`95.83% <100%> (+0.18%)`	⬆️
...ntrollers/decidim/admin/static_pages_controller.rb	`100% <100%> (ø)`	⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc421e...e31b1f5. Read the comment docs.

* Review all the forms * Class coherence review

andreslucena · 2017-03-29T11:34:44Z

@lastpotion

@andreslucena We are nearly finish fixing all those issues. But, regarding the missing translations, they'll be updated when we merge the new admin with master and pass them through Crowdin.

Ok, pefect!

Also after looking how to implement the date-picker we decide to create a new branch to deal with later (https://github.com/AjuntamentdeBarcelona/decidim/tree/admin/datepicker). Since we found a couple of problems we need to face to implement it.

Ok, no worries. Maybe we also need a datetimepicker for Start and End DateTime on Meetings.

Also I've detected:

Usability error on i18n tabs on forms (everyone): when I save and get an error it isn't so clear that the message has happened. The label is red, and when I click on the secondary language (spanish) I can see the input red border, but it just doesn't feel good. (Maybe this belongs to an issue on decidim-design-admin)
Styles missing on Debates: https://decidim-barcelona-pr-91.herokuapp.com/admin/participatory_processes/2/features/17/manage - This is a feature for decidim-barcelona instance only.
On an image upload edit, if there is any image already uploaded, I should see that image (for instance on https://decidim-barcelona-pr-91.herokuapp.com/admin/organization/edit)

beagleknight · 2017-03-29T12:57:05Z

Hi @andreslucena !

Usability error on i18n tabs on forms (everyone): when I save and get an error it isn't so clear that the message has happened. The label is red, and when I click on the secondary language (spanish) I can see the input red border, but it just doesn't feel good. (Maybe this belongs to an issue on decidim-design-admin)

Styles missing on Debates: https://decidim-barcelona-pr-91.herokuapp.com/admin/participatory_processes/2/features/17/manage - This is a feature for decidim-barcelona instance only.

I created an issue for each task because the first one it was also present on the previous admin so we are gonna treat it as a separated task.
For the Debates section we'll gonna start working on it after the new admin is in the master branch 😄 .

Finally, I added preview images in the form as a minor workaround because we don't have design for this right now. If @htmlboy can give us some insights about this it will be great 😄

andreslucena · 2017-03-29T13:28:01Z

@beagleknight perfect!
Yes, please, any other report that you see that isn't low hanging fruit for this PR just move it to another issue. Regarding the unpublish icon, this is what I'm talking about:

On the good side, I didn't see anything that's a show stopper to merge this, so if you guys see it clear just merge if you see it clear. Great job guys! 👏 👏 👏 👏 👏

beagleknight · 2017-03-29T13:34:39Z

@andreslucena Oops! I forgot about the icons, you are right! We are going to find a better one for the publish / unpublish. I think we could do something like the steps:

But I'm no usability expert so... what do you think @htmlboy ?

htmlboy · 2017-03-29T13:46:14Z

@beagleknight An icon like a "cross" or "forbidden" is definitely better than "download from the cloud" to "unpublish" something :-)

lastpotion · 2017-03-30T07:36:39Z

I just updated the features table with a couple new icons: check to publish and X to unpublish, thoughts?

htmlboy · 2017-03-30T07:51:17Z

@lastpotion Looks good! :-)

josepjaume added the in-progress label Mar 10, 2017

josepjaume changed the title ~~Add admin styles~~ Admin panel refactor Mar 13, 2017

beagleknight self-assigned this Mar 13, 2017

beagleknight mentioned this pull request Mar 14, 2017

New admin - Settings section #1115

Merged

3 tasks

beagleknight force-pushed the revamp_admin branch 3 times, most recently from 0610cb0 to e470ecd Compare March 15, 2017 09:34

This was referenced Mar 15, 2017

New admin - Settings section #1124

Merged

[New admin] - Pages section #1130

Merged

[New admin] - Users #1136

Merged

[New admin] - Newsletters #1140

Merged

lastpotion mentioned this pull request Mar 16, 2017

[New Admin] - Processes info / steps #1138

Merged

6 tasks

beagleknight mentioned this pull request Mar 16, 2017

[New Admin] - Process groups #1141

Merged

2 tasks

This was referenced Mar 20, 2017

[New Admin] - Style process features #1143

Merged

Style process features at admin #1149

Merged

Add icon link helper #1155

Merged

lastpotion mentioned this pull request Mar 21, 2017

[New Admin] Update category views. #1148

Merged

2 tasks

beagleknight force-pushed the revamp_admin branch from b984416 to 19d290b Compare March 21, 2017 11:00

This was referenced Mar 22, 2017

[New Admin] Attachment update. #1158

Merged

[New Admin] Attachment delete method redirect to processes show. #1163

Closed

beagleknight assigned lastpotion and ItsGenis Mar 27, 2017

This was referenced Mar 27, 2017

Admin Dashboard #1180

Closed

Admin Language selector #1181

Closed

ItsGenis mentioned this pull request Mar 27, 2017

Style moderation tables #1182

Merged

This was referenced Mar 27, 2017

Match the rich text editor style with the new admin #1184

Closed

Improve selects with multiple options #1185

Closed

New admin I18n revision #1186

Closed

beagleknight and others added 8 commits March 29, 2017 12:33

Add styles for feature forms

90a6fb6

Add edit feature form

ee63362

Add more feedback

9640fe8

[New Admin] Html and styles review. (#1200)

d148cbc

* Review all the forms * Class coherence review

CA: Swap funcionalitat with component

9713b93

Fix a few specs

43db91d

ES: Swap funcionalidad with componente

d5bc8f0

Fix a few more specs

757711c

beagleknight force-pushed the revamp_admin branch from 2ae3ecf to 757711c Compare March 29, 2017 10:41

Add missing helper

119a375

This was referenced Mar 29, 2017

Highlight errors in forms when translations are missing #1201

Closed

[New Admin] - Debates section AjuntamentdeBarcelona/decidim-barcelona#92

Closed

Add preview images to organization settings form

9a6da5a

oriolgual approved these changes Mar 29, 2017

View reviewed changes

Icons updated on features table

3a94665

amend icon

e31b1f5

beagleknight merged commit b7ba67d into master Mar 30, 2017

beagleknight removed the in-review label Mar 30, 2017

lastpotion mentioned this pull request Mar 30, 2017

Update all date fields to designed date-picker. #1204

Closed

beagleknight deleted the revamp_admin branch April 3, 2017 08:51

mrcasals mentioned this pull request Apr 5, 2017

Read missing official image inputs #1225

Merged

oriolgual unassigned ItsGenis Apr 21, 2017

Quentinchampenois pushed a commit to Quentinchampenois/decidim that referenced this pull request Mar 8, 2021

Avoid security issue (decidim#1101)

aa3a4b3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Admin panel refactor#1101

Admin panel refactor#1101
beagleknight merged 37 commits intomasterfrom
revamp_admin

josepjaume commented Mar 10, 2017 •

edited by beagleknight

Loading

Uh oh!

codecov-io commented Mar 14, 2017

Uh oh!

codecov-io commented Mar 14, 2017 •

edited

Loading

Uh oh!

andreslucena commented Mar 29, 2017

Uh oh!

beagleknight commented Mar 29, 2017

Uh oh!

andreslucena commented Mar 29, 2017

Uh oh!

beagleknight commented Mar 29, 2017

Uh oh!

htmlboy commented Mar 29, 2017

Uh oh!

lastpotion commented Mar 30, 2017 •

edited

Loading

Uh oh!

htmlboy commented Mar 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

josepjaume commented Mar 10, 2017 • edited by beagleknight Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎩 What? Why?

📝 Documentation

📌 Related Issues

📋 Subtasks

📷 Screenshots (optional)

👻 GIF

Uh oh!

codecov-io commented Mar 14, 2017

Codecov Report

Uh oh!

codecov-io commented Mar 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

andreslucena commented Mar 29, 2017

Uh oh!

beagleknight commented Mar 29, 2017

Uh oh!

andreslucena commented Mar 29, 2017

Uh oh!

beagleknight commented Mar 29, 2017

Uh oh!

htmlboy commented Mar 29, 2017

Uh oh!

lastpotion commented Mar 30, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

htmlboy commented Mar 30, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

josepjaume commented Mar 10, 2017 •

edited by beagleknight

Loading

codecov-io commented Mar 14, 2017 •

edited

Loading

lastpotion commented Mar 30, 2017 •

edited

Loading