[New Admin] Attachment update.#1158
Merged
lastpotion merged 3 commits intorevamp_adminfrom Mar 23, 2017
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## revamp_admin #1158 +/- ##
=============================================
Coverage 97.09% 97.09%
=============================================
Files 422 422
Lines 7048 7048
=============================================
Hits 6843 6843
Misses 205 205Continue to review full report at Codecov.
|
db179ce to
6ffab65
Compare
oriolgual
approved these changes
Mar 22, 2017
ItsGenis
suggested changes
Mar 22, 2017
| <% attached_to.attachments.each do |attachment| %> | ||
| <tr data-id="<%= attachment.id %>"> | ||
| <td> | ||
| <%= link_to translated_attribute(attachment.title), polymorphic_path([attached_to, attachment]) %><br /> |
Contributor
There was a problem hiding this comment.
I think we are removing title links in favor of eye icon links.
Contributor
There was a problem hiding this comment.
As we've discussed offline we will prioritize icon links for actions outside the admin panel and the title links otherwise.
ItsGenis
approved these changes
Mar 23, 2017
beagleknight
pushed a commit
that referenced
this pull request
Mar 27, 2017
* Views added * Finish tests * add helper
beagleknight
pushed a commit
that referenced
this pull request
Mar 28, 2017
* Views added * Finish tests * add helper
beagleknight
pushed a commit
that referenced
this pull request
Mar 29, 2017
* Views added * Finish tests * add helper
beagleknight
pushed a commit
that referenced
this pull request
Mar 30, 2017
* Add admin styles * Add basic layout * Change scopes icon * Add participatory processes index page * Add participatory process layout * Fix some specs * Fix more broken tests * Fix more specs * Fix poltergeist * New admin - Settings section (#1124) * Add participatory process layout * Add basic layout for settings * Finish settings form * Add scopes index page * Finish basic scopes admin * Add revamp_admin to travis * Fix a few specs * Fix broken tests * Remove bad merge * [New admin] - Pages section (#1130) * Add index section * Add new section * Finish forms * Fix specs * [New admin] - Users (#1136) * Add layout * Add users index page * Add invite user form * Add user groups index and fix pagination for both users and user groups * Fix table links * Fix specs * Fix admin invite user labels * [New admin] - Newsletters (#1140) * Add layout and index page * Add new/edit forms * Add newsletter preview * Fix specs * [New Admin] - Process groups (#1141) * Add new views * Fix broken specs * [New Admin] - Style process features (#1143) * Style process features * Refactor feature tests for admin * [New Admin] - Processes info / steps (#1138) * updated new process view * updated process steps index * update process steps index table * update processes layouts * Processes steps views updated * Fix indentation * Remove unusued locales * Update tests * Add moderations missing menu * missing td added * Add icon link helper (#1155) * Add icon link helper * Update existing icon links * Add optional data to icon link helper * Add methods at icon links * Refactor tests for new icon helper * Add docs and refactor helper call * Refactor all icon links with new helper call * [New Admin] Update category views. (#1148) * Add category views * Fix tests * Add tests * Add new icon_helper * [New Admin] Attachment update. (#1158) * Views added * Finish tests * add helper * Style process features at admin (#1149) * [New Admin] - Process groups (#1141) * Add new views * Fix broken specs * Style meetings table * Update branch with icon helper * Style proposals * Style results * Style budgets * Update missing styles for some forms * Fix most of the tests * Fix more tests * Style moderation tables (#1182) * Remove unused travis step * [New Admin] Update process admins views. (#1183) * Add new and edit forms * clean update command * Tests added * Amend test * Add dashboard content * Spellcheck * Amend managing roles strings * Use user instead of admin * Fix participatory process edit button * Add some feedback * Add styles for feature forms * Add edit feature form * Add more feedback * [New Admin] Html and styles review. (#1200) * Review all the forms * Class coherence review * CA: Swap funcionalitat with component * Fix a few specs * ES: Swap funcionalidad with componente * Fix a few more specs * Add missing helper * Add preview images to organization settings form * Icons updated on features table * amend icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎩 What? Why?
Update attachment section inside a process with the new admin views and styles.
📌 Related Issues
📋 Subtasks
📷 Screenshots (optional)
👻 GIF