Skip to content

sql: decrease job adopt interval for schema change tests#45992

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
thoszhang:test-adopt-interval
Mar 11, 2020
Merged

sql: decrease job adopt interval for schema change tests#45992
craig[bot] merged 1 commit intocockroachdb:masterfrom
thoszhang:test-adopt-interval

Conversation

@thoszhang
Copy link
Copy Markdown

This PR decreases the job adopt interval to 100 ms for some schema
change tests for retries, so that the job registry adopts the jobs to
retry more quickly. These test were taking over a minute after the
schema change job refactor, and now take about 1 second.

Closes #45970.

Release justification: This change only fixes tests.
Release note: None

This PR decreases the job adopt interval to 100 ms for some schema
change tests for retries, so that the job registry adopts the jobs to
retry more quickly. These test were taking over a minute after the
schema change job refactor, and now take about 1 second.

Release justification: This change only fixes tests.
Release note: None
@thoszhang thoszhang requested review from dt and spaskob March 11, 2020 16:34
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Contributor

@spaskob spaskob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dt and @spaskob)

@thoszhang
Copy link
Copy Markdown
Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 11, 2020

Build succeeded

@craig craig bot merged commit e70c4ee into cockroachdb:master Mar 11, 2020
@thoszhang thoszhang deleted the test-adopt-interval branch March 12, 2020 01:26
ajwerner pushed a commit to ajwerner/cockroach that referenced this pull request Mar 17, 2020
This commit is a follow up to cockroachdb#45992. It adds some tests that were missed and
refactors the setup to a helper.

Fixes cockroachdb#45970.

```
--- PASS: TestPrimaryKeyChangeWithPrecedingIndexCreation (1.04s)
--- PASS: TestCRUDWhileColumnBackfill (0.73s)
--- PASS: TestIndexBackfillAfterGC (0.74s)
--- PASS: TestSchemaChangeGRPCError (0.67s)
--- PASS: TestFKReferencesAddedOnlyOnceOnRetry (0.50s)
```

Release justification: non-production code changes

Release note: None
craig bot pushed a commit that referenced this pull request Mar 17, 2020
46047: ui: Fix OOM exception while building Karma tests r=dhartunian a=koorosh

This exception was fixed in past and that
time main root cause was tied to Helmet library.

Now this OOM exception more likely is caused by
increasing code base.
Previously, webpack configuration provided to Karma
contained `devtool = sourcemap` and might caused
growing memory usage along with increased codebase.

To mitigate this problem as a quick fix during
stabilization period, following non-production
changes were made:
- Changed source maps generation for karma tests
to use lightweight 'eval' option
- `Sourcemap` preprocessors are removed

While testing locally, I couldn't get OOM exception
with following configs.

Related issue in Karma repo: karma-runner/karma#1868 (comment)

Release justification: Non-production code change

Release note: None

46132: sql: trace execution stats for query diagnostics r=RaduBerinde a=RaduBerinde

The distsql processors are initialized with the Context in the eval context. If
this context contains a tracing span that is recording, the processors will set
up statistics collection and put them in the span as tags.

The statement diagnostics code sets up a span but doesn't change this context,
so statistics collection doesn't happen. We want these statistics in the trace,
as they will soon be used to generate EXPLAIN ANALYZE diagrams for the bundles.

This change fixes this issue and moves up the initialization of the planner so
we can tweak it directly, which simplifies code.

Release note (bug fix): statement diagnostics traces now contain processor
statistics.

Release justification: Bug fixes and low-risk updates to new functionality

46179: sql: decrease job adopt interval for more schema change tests r=lucy-zhang a=ajwerner

This commit is a follow up to #45992. It adds some tests that were missed and
refactors the setup to a helper.

Fixes #45970.

```
--- PASS: TestPrimaryKeyChangeWithPrecedingIndexCreation (1.04s)
--- PASS: TestCRUDWhileColumnBackfill (0.73s)
--- PASS: TestIndexBackfillAfterGC (0.74s)
--- PASS: TestSchemaChangeGRPCError (0.67s)
--- PASS: TestFKReferencesAddedOnlyOnceOnRetry (0.50s)
```

Release justification: non-production code changes

Release note: None

Co-authored-by: Andrii Vorobiov <and.vorobiov@gmail.com>
Co-authored-by: Radu Berinde <radu@cockroachlabs.com>
Co-authored-by: Andrew Werner <ajwerner@cockroachlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: TestSchemaChangeRetry, TestSchemaChangeRetryOnVersionChange started taking a minute after jobs change

4 participants