ui: Fix OOM exception while building Karma tests#46047
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 17, 2020
Merged
ui: Fix OOM exception while building Karma tests#46047craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
dhartunian
approved these changes
Mar 16, 2020
Collaborator
|
bors r+ |
Contributor
Build failed (retrying...) |
Contributor
Build failed |
Collaborator
|
bors r- |
Collaborator
|
@koorosh sorry forgot to request: please add release justification to both the PR message and the commit:
This should be right above the |
This exception was fixed in past and that time main root cause was tied to Helmet library. Now this OOM exception more likely is caused by increasing code base. Previously, webpack configuration provided to Karma contained `devtool = sourcemap` and might caused growing memory usage along with increased codebase. To mitigate this problem as a quick fix during stabilization period, following non-production changes were made: - Changed source maps generation for karma tests to use lightweight 'eval' option - `Sourcemap` preprocessors are removed While testing locally, I couldn't get OOM exception with following configs. Related issue in Karma repo: karma-runner/karma#1868 (comment) Release justification: Non-production code change Release note: None
60fb1d0 to
eb297d5
Compare
Contributor
Author
Done! |
Collaborator
|
bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This exception was fixed in past and that
time main root cause was tied to Helmet library.
Now this OOM exception more likely is caused by
increasing code base.
Previously, webpack configuration provided to Karma
contained
devtool = sourcemapand might causedgrowing memory usage along with increased codebase.
To mitigate this problem as a quick fix during
stabilization period, following non-production
changes were made:
to use lightweight 'eval' option
Sourcemappreprocessors are removedWhile testing locally, I couldn't get OOM exception
with following configs.
Related issue in Karma repo: karma-runner/karma#1868 (comment)
Release justification: Non-production code change
Release note: None