sql: trace execution stats for query diagnostics#46132
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Mar 17, 2020
Merged
sql: trace execution stats for query diagnostics#46132craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
andreimatei
reviewed
Mar 16, 2020
Contributor
andreimatei
left a comment
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
5f0585b to
4eefb0d
Compare
Member
|
cc @asubiotto |
Member
Author
|
bors r+ |
Member
Author
|
bors r- Seems like it's still not working well for subqueries. |
Contributor
Canceled |
The distsql processors are initialized with the Context in the eval context. If this context contains a tracing span that is recording, the processors will set up statistics collection and put them in the span as tags. The statement diagnostics code sets up a span but doesn't change this context, so statistics collection doesn't happen. We want these statistics in the trace, as they will soon be used to generate EXPLAIN ANALYZE diagrams for the bundles. This change fixes this issue and moves up the initialization of the planner so we can tweak it directly, which simplifies code. Release note (bug fix): statement diagnostics traces now contain processor statistics. Release justification: Bug fixes and low-risk updates to new functionality
4eefb0d to
e7afadb
Compare
Member
Author
|
Added similar code for the Context used by sub/postqueries, PTAL. |
Member
Author
|
bors r+ |
Contributor
Build succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The distsql processors are initialized with the Context in the eval context. If
this context contains a tracing span that is recording, the processors will set
up statistics collection and put them in the span as tags.
The statement diagnostics code sets up a span but doesn't change this context,
so statistics collection doesn't happen. We want these statistics in the trace,
as they will soon be used to generate EXPLAIN ANALYZE diagrams for the bundles.
This change fixes this issue and moves up the initialization of the planner so
we can tweak it directly, which simplifies code.
Release note (bug fix): statement diagnostics traces now contain processor
statistics.
Release justification: Bug fixes and low-risk updates to new functionality