Skip to content

sql: decrease job adopt interval for more schema change tests#46179

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/speed-up-sql-tests
Mar 17, 2020
Merged

sql: decrease job adopt interval for more schema change tests#46179
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/speed-up-sql-tests

Conversation

@ajwerner
Copy link
Copy Markdown
Contributor

This commit is a follow up to #45992. It adds some tests that were missed and
refactors the setup to a helper.

Fixes #45970.

--- PASS: TestPrimaryKeyChangeWithPrecedingIndexCreation (1.04s)
--- PASS: TestCRUDWhileColumnBackfill (0.73s)
--- PASS: TestIndexBackfillAfterGC (0.74s)
--- PASS: TestSchemaChangeGRPCError (0.67s)
--- PASS: TestFKReferencesAddedOnlyOnceOnRetry (0.50s)

Release justification: non-production code changes

Release note: None

This commit is a follow up to cockroachdb#45992. It adds some tests that were missed and
refactors the setup to a helper.

Fixes cockroachdb#45970.

```
--- PASS: TestPrimaryKeyChangeWithPrecedingIndexCreation (1.04s)
--- PASS: TestCRUDWhileColumnBackfill (0.73s)
--- PASS: TestIndexBackfillAfterGC (0.74s)
--- PASS: TestSchemaChangeGRPCError (0.67s)
--- PASS: TestFKReferencesAddedOnlyOnceOnRetry (0.50s)
```

Release justification: non-production code changes

Release note: None
@ajwerner ajwerner requested a review from thoszhang March 17, 2020 04:43
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown

@thoszhang thoszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@ajwerner
Copy link
Copy Markdown
Contributor Author

bors r=lucy-zhang

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 17, 2020

Build failed (retrying...)

@ajwerner
Copy link
Copy Markdown
Contributor Author

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Mar 17, 2020

Build succeeded

@craig craig bot merged commit bbe20c3 into cockroachdb:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: TestSchemaChangeRetry, TestSchemaChangeRetryOnVersionChange started taking a minute after jobs change

3 participants