43265: storage: clean up usages of `{eng,batch} engine.{Reader,Writer,ReadWriter}` r=irfansharif a=irfansharif

We should be using `{reader,writer,readWriter} engine.{Reader,Writer,ReadWriter}` instead. See individual commits for review.

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>

43271: engine: clean up variable names of `{Reader,Writer,ReadWriter}` types r=irfansharif a=irfansharif

We should be using {reader,writer,readWriter} for
{Reader,Writer,ReadWriter} respectively instead.

(Same thing as #43265, but for pkg/storage/engine).

Release note: None

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>

Leftover work from cockroachdb#43265.

Release note: None

43372: storage: rename `{e,b} engine.{Reader,Writer,ReadWriter}` r=petermattis a=irfansharif

Leftover work from #43265.

Release note: None

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>

…types

We should be using {reader,readWriter} for
{Reader,ReadWriter} respectively instead. I'd skipped everything under
batcheval when working on cockroachdb#43265, back when I thought it'd be a good
idea to plumb in an engine.Batch throughout replica read codepaths. Due
to perf penalty as seen on cockroachdb#43388, I'm no longer going to be doing that.
This is the remaining work.

Release note: None

…types

We should be using {reader,readWriter} for
{Reader,ReadWriter} respectively instead. I'd skipped everything under
`batcheval` when working on cockroachdb#43265, back when I thought it'd be a good
idea to plumb in an engine.Batch throughout replica read codepaths. Due
to perf penalty as seen on cockroachdb#43388, I'm no longer going to be doing that.
This is the remaining work.

Release note: None

43792: batcheval: clean up remaning variable names of `{Reader,ReadWriter}` types r=irfansharif a=irfansharif

Ignore first commit, reviewed in #43764. 

We should be using {reader,readWriter} for
{Reader,ReadWriter} respectively instead. I'd skipped everything under
batcheval when working on #43265, back when I thought it'd be a good
idea to plumb in an engine.Batch throughout replica read codepaths. Due
to perf penalty as seen on #43388, I'm no longer going to be doing that.
This is the remaining work.

Release note: None


43811: hba: stricter parsing and better pretty-printing r=knz a=knz

The following defects were found by @mjibson using
`go-fuzz` (#43805) and are fixed by this patch:

- the code would parse then fail to pretty-print an empty connection
  type and auth method.
- the code would parse then pretty-print incorrectly a connection
  type or auth method containing commas or other special characters.
- the code would accept an empty string as address.
- the code would accept then fail to pretty-print columns containing
  special (control) characters.

Note that the code previously supported tabs (\t) and carriage
returns (\r) inside quoted strings, and this is now rejected. For most
fields, this does not matter, as these special characters were not
valid semantically anyway.

However, for the method options in the last column it is theoretically
possible for a method to wish to use such special characters. This is
not currently the case for the CCL `gss` method already implemented,
so this change is not introducing a regression. A comment is left in
the code to indicate what needs to be changed if a future method needs
this support.

Release note (security): CockroachDB now properly rejects control
characters in the value of the cluster setting
`server.host_based_authentication.configuration`. These characters
were previously accepted and would silently yield rules matching
differently from intended. Deployments careful to strip control
characters from their HBA configuration are not affected.

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>