Skip to content

batcheval: clean up remaning variable names of {Reader,ReadWriter} types#43792

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:200107.batcheval-rename
Jan 8, 2020
Merged

batcheval: clean up remaning variable names of {Reader,ReadWriter} types#43792
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:200107.batcheval-rename

Conversation

@irfansharif
Copy link
Copy Markdown
Contributor

Ignore first commit, reviewed in #43764.

We should be using {reader,readWriter} for
{Reader,ReadWriter} respectively instead. I'd skipped everything under
batcheval when working on #43265, back when I thought it'd be a good
idea to plumb in an engine.Batch throughout replica read codepaths. Due
to perf penalty as seen on #43388, I'm no longer going to be doing that.
This is the remaining work.

Release note: None

@irfansharif irfansharif requested a review from nvb January 7, 2020 19:47
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

…types

We should be using {reader,readWriter} for
{Reader,ReadWriter} respectively instead. I'd skipped everything under
`batcheval` when working on cockroachdb#43265, back when I thought it'd be a good
idea to plumb in an engine.Batch throughout replica read codepaths. Due
to perf penalty as seen on cockroachdb#43388, I'm no longer going to be doing that.
This is the remaining work.

Release note: None
@irfansharif irfansharif force-pushed the 200107.batcheval-rename branch from 0363638 to 64e3f46 Compare January 7, 2020 23:44
Copy link
Copy Markdown
Contributor

@nvb nvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: though readWriter is fairly large and I'd be equally ok with s/readWriter/rw/ and s/reader/r/. Did you have a reason for not doing that?

Reviewed 35 of 35 files at r1.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

Copy link
Copy Markdown
Contributor Author

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTR! I was keeping the naming consistent with our usage in pkg/storage. That being said, this area will be seeing a few more passes shortly. Specifically, we're going to be introducing a raftrw var all over, I'll be cleaning these up as that work gets pulled in.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained

@irfansharif
Copy link
Copy Markdown
Contributor Author

bors r+

craig bot pushed a commit that referenced this pull request Jan 8, 2020
43792: batcheval: clean up remaning variable names of `{Reader,ReadWriter}` types r=irfansharif a=irfansharif

Ignore first commit, reviewed in #43764. 

We should be using {reader,readWriter} for
{Reader,ReadWriter} respectively instead. I'd skipped everything under
batcheval when working on #43265, back when I thought it'd be a good
idea to plumb in an engine.Batch throughout replica read codepaths. Due
to perf penalty as seen on #43388, I'm no longer going to be doing that.
This is the remaining work.

Release note: None


43811: hba: stricter parsing and better pretty-printing r=knz a=knz

The following defects were found by @mjibson using
`go-fuzz` (#43805) and are fixed by this patch:

- the code would parse then fail to pretty-print an empty connection
  type and auth method.
- the code would parse then pretty-print incorrectly a connection
  type or auth method containing commas or other special characters.
- the code would accept an empty string as address.
- the code would accept then fail to pretty-print columns containing
  special (control) characters.

Note that the code previously supported tabs (\t) and carriage
returns (\r) inside quoted strings, and this is now rejected. For most
fields, this does not matter, as these special characters were not
valid semantically anyway.

However, for the method options in the last column it is theoretically
possible for a method to wish to use such special characters. This is
not currently the case for the CCL `gss` method already implemented,
so this change is not introducing a regression. A comment is left in
the code to indicate what needs to be changed if a future method needs
this support.

Release note (security): CockroachDB now properly rejects control
characters in the value of the cluster setting
`server.host_based_authentication.configuration`. These characters
were previously accepted and would silently yield rules matching
differently from intended. Deployments careful to strip control
characters from their HBA configuration are not affected.

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
Co-authored-by: Raphael 'kena' Poss <knz@thaumogen.net>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jan 8, 2020

Build succeeded

@craig craig bot merged commit 64e3f46 into cockroachdb:master Jan 8, 2020
@irfansharif irfansharif deleted the 200107.batcheval-rename branch January 8, 2020 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants