Skip to content

storage: rename {e,b} engine.{Reader,Writer,ReadWriter}#43372

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:191219.rename-eng
Dec 19, 2019
Merged

storage: rename {e,b} engine.{Reader,Writer,ReadWriter}#43372
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:191219.rename-eng

Conversation

@irfansharif
Copy link
Copy Markdown
Contributor

@irfansharif irfansharif commented Dec 19, 2019

Leftover work from #43265.

Release note: None

@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Dec 19, 2019

This change is Reviewable

@irfansharif irfansharif requested a review from nvb December 19, 2019 21:50
petermattis
petermattis approved these changes Dec 19, 2019
View reviewed changes
Copy link
Copy Markdown
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @irfansharif and @nvanbenschoten)

pkg/storage/abortspan/abortspan.go, line 131 at r1 (raw file):

func (sc *AbortSpan) Put(
	ctx context.Context,
	readWriter engine.ReadWriter,

Nit: s/readWriter/rw/g

irfansharif
irfansharif commented Dec 19, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@irfansharif irfansharif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten and @petermattis)

pkg/storage/abortspan/abortspan.go, line 131 at r1 (raw file):

Previously, petermattis (Peter Mattis) wrote…

Nit: s/readWriter/rw/g

I'm going to leave this one as is for now, I used rw at the pkg/storage/engine level and had readWriter at the pkg/storage level from earlier. I'll look to swap it out as I'm making more changes to use engine.Batch more pervasively instead of engine.ReadWriter in incoming PRs.

@irfansharif
Copy link
Copy Markdown
Contributor Author

irfansharif commented Dec 19, 2019

bors r=petermattis

craig bot pushed a commit that referenced this pull request Dec 19, 2019
@irfansharif
Merge #43372
ca4dec6 
43372: storage: rename `{e,b} engine.{Reader,Writer,ReadWriter}` r=petermattis a=irfansharif

Leftover work from #43265.

Release note: None

Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Dec 19, 2019

Build succeeded

@craig craig bot merged commit 4c6ef49 into cockroachdb:master Dec 19, 2019
@irfansharif irfansharif deleted the 191219.rename-eng branch December 19, 2019 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@petermattis petermattis petermattis approved these changes

@nvb nvb Awaiting requested review from nvb

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@irfansharif @cockroach-teamcity @petermattis