engine: clean up variable names for {Reader,Writer,ReadWriter} types#43271
Conversation
|
This change is |
petermattis
left a comment
There was a problem hiding this comment.
Did you use a tool (e.g. go-rename) to automate this?
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @irfansharif, @nvanbenschoten, and @petermattis)
pkg/storage/engine/engine_test.go, line 247 at r1 (raw file):
} apply := func(readWriter ReadWriter, d data) error {
There is a bit of stuttering in this naming. How do you feel about s/readWriter/rw/g?
a7ccb79 to
b15d5a8
Compare
There was a problem hiding this comment.
TFTR. Just used sed to change out function signatures breaking the build, then used regular ol' search and replace to fix after the fact.
Reviewable status:
pkg/storage/engine/engine_test.go, line 247 at r1 (raw file):
Previously, petermattis (Peter Mattis) wrote…
There is a bit of stuttering in this naming. How do you feel about
s/readWriter/rw/g?
Done.
We should be using {reader,writer,readWriter} for
{Reader,Writer,ReadWriter} respectively instead.
Release note: None
b15d5a8 to
886bb96
Compare
|
bors r+ |
43271: engine: clean up variable names of `{Reader,Writer,ReadWriter}` types r=irfansharif a=irfansharif
We should be using {reader,writer,readWriter} for
{Reader,Writer,ReadWriter} respectively instead.
(Same thing as #43265, but for pkg/storage/engine).
Release note: None
Co-authored-by: irfan sharif <irfanmahmoudsharif@gmail.com>
{Reader,Writer,ReadWriter} types{Reader,Writer,ReadWriter} types
Build succeeded |
We should be using {reader,writer,readWriter} for
{Reader,Writer,ReadWriter} respectively instead.
(Same thing as #43265, but for pkg/storage/engine).
Release note: None