ccl/multiregionccl: make multi-region dd less flaky#109050
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 21, 2023
Merged
ccl/multiregionccl: make multi-region dd less flaky#109050craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously, it was possible for lease transfers to be initiated in-between assertions which relied on a steady leaseholder. This commit reduces the likelihood of lease transfers which would break assumptions the `TestMultiRegionDataDriven` test makes, by stopping load based rebalancing, and follow-the-workload lease transfers. Informs: cockroachdb#108759 Release note: None
Member
|
This change is |
rafiss
approved these changes
Aug 21, 2023
Collaborator
rafiss
left a comment
There was a problem hiding this comment.
nice!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @kvoli)
Contributor
Author
|
TYFTR bors r=rafiss |
Contributor
|
Build succeeded: |
This was referenced Aug 21, 2023
kvoli
added a commit
to kvoli/cockroach
that referenced
this pull request
Aug 31, 2023
Previously, `TestMultiRegionDataDriven` allowed kvserver (replicate queue) lease transfers to occur for lease count rebalancing. Load based rebalancing was disabled in an earlier patch cockroachdb#109050, however we saw in interleaving replication changes -- leading to flaky behavior. Bump the `kv.allocator.min_lease_transfer_interval` to 5 minutes, effectively disabling internal lease transfers. Lease transfers which are required for lease preference satisfaction, and manual transfers are still permitted. Fixes: cockroachdb#109215 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Sep 1, 2023
109819: ccl/multiregionccl: deflake multi-region datadriven test r=rafiss a=kvoli Previously, `TestMultiRegionDataDriven` allowed kvserver (replicate queue) lease transfers to occur for lease count rebalancing. Load based rebalancing was disabled in an earlier patch #109050, however we saw in interleaving replication changes -- leading to flaky behavior. Bump the `kv.allocator.min_lease_transfer_interval` to 5 minutes, effectively disabling internal lease transfers. Lease transfers which are required for lease preference satisfaction, and manual transfers are still permitted. Fixes: #109215 Release note: None --- `TestMultiRegionDataDriven` speeds up replication changes by proactively enqueuing replicas into various queues. This has the benefit of reducing the time taken after zone config changes, however the downside of added overhead. Disable the test under deadlock builds, as the test is slow and susceptible to (legitimate) timing issues on a deadlock build. Informs: #109215 Release note: None 109826: jobs: add a reference to the resumer in the claimed jobs map r=dt a=adityamaru This change adds a reference to the resumer in the map maintained by every registry of the jobs that it has claimed. This will be used in a follow up commit to request the resumer to dump its job profiler details on demand as explained in Informs: #109671 Release note: None 109907: workload/indexes: support insert and update workloads r=DrewKimball,srosenberg a=nvanbenschoten This commit adds support for Insert and Update statements in the indexes workload. Insert statements will fail if they find a collision and update statements will fail if they don't, so each workload has specific requirements, which are documented on the flag. Epic: None Release note: None Co-authored-by: Austen McClernon <austen@cockroachlabs.com> Co-authored-by: adityamaru <adityamaru@gmail.com> Co-authored-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
kvoli
added a commit
to kvoli/cockroach
that referenced
this pull request
Sep 5, 2023
Previously, `TestMultiRegionDataDriven` allowed kvserver (replicate queue) lease transfers to occur for lease count rebalancing. Load based rebalancing was disabled in an earlier patch cockroachdb#109050, however we saw in interleaving replication changes -- leading to flaky behavior. Bump the `kv.allocator.min_lease_transfer_interval` to 5 minutes, effectively disabling internal lease transfers. Lease transfers which are required for lease preference satisfaction, and manual transfers are still permitted. Fixes: cockroachdb#109215 Release note: None
kvoli
added a commit
to kvoli/cockroach
that referenced
this pull request
Sep 5, 2023
Previously, `TestMultiRegionDataDriven` allowed kvserver (replicate queue) lease transfers to occur for lease count rebalancing. Load based rebalancing was disabled in an earlier patch cockroachdb#109050, however we saw in interleaving replication changes -- leading to flaky behavior. Bump the `kv.allocator.min_lease_transfer_interval` to 5 minutes, effectively disabling internal lease transfers. Lease transfers which are required for lease preference satisfaction, and manual transfers are still permitted. Fixes: cockroachdb#109215 Release note: None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, it was possible for lease transfers to be initiated in-between assertions which relied on a steady leaseholder.
This commit reduces the likelihood of lease transfers which would break assumptions the
TestMultiRegionDataDriventest makes, by stopping load based rebalancing, and follow-the-workload lease transfers.Informs: #108759
Release note: None