-
Notifications
You must be signed in to change notification settings - Fork 4.1k
jobsprofiler: add ExecutionDetails method to the Resumer interface #109671
Copy link
Copy link
Closed
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-disaster-recovery
Description
All of the jobs that have integrated with the jobs profiler so far (backup, restore, C2C) rely on each resumer having a timer based loop and periodically writing state to the job_info table. Which is then surfaced in the Advanced Debugging page. While this works we want to move towards a model where information is only persisted to the job_info table if it has been requested or the job is in a "profiling" mode. To achieve this model we should:
- Ensure requesting of execution details is always evaluated on the job's current coordinator.
- Add an
ExecutionDetailsmethod to the Resumer interface so that each Resumer can determine what they want to do when such details are requested. - Teach the request execution details logic to call this method on the resumer.
A follow up after this will be to allow every job to mark whether it is being profiled or not. When a job is being profiled we should add logic to automatically request these execution details at some configurable rate.
Epic: CRDB-8964
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
C-enhancementSolution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)T-disaster-recovery